Bug 253758 - Correct name of ~/.login in handbook
Summary: Correct name of ~/.login in handbook
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Ebdrup Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-22 11:00 UTC by Ceri Davies
Modified: 2021-02-22 19:57 UTC (History)
1 user (show)

See Also:


Attachments
correct path to ~/.login (880 bytes, patch)
2021-02-22 11:00 UTC, Ceri Davies
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ceri Davies 2021-02-22 11:00:33 UTC
Created attachment 222719 [details]
correct path to ~/.login

The l10n chapter directs people to add things to ~/.csh.login but that's not the right path - ~/.login is.
Comment 1 Daniel Ebdrup Jensen freebsd_committer 2021-02-22 17:54:43 UTC
I'll take this, and sooner or later I'm going to convince someone to reactivate your commit bit. :P
Comment 2 Daniel Ebdrup Jensen freebsd_committer 2021-02-22 18:25:24 UTC
Upon closer inspection, this isn't a bug.

The section deals with csh-specific syntax for setting environment variables when csh is started.
The files ~/login_conf.db or /etc/login.conf.db apply environment variables to more than the shell and system-wide, respectively, are both shell-independent.

If you want to fix this, I would recommend rewriting this to instruct people to modify /etc/login.conf and use cap_mkdb(1) to regenerate the database, so you're welcome to submit that as a new report.

It'd also help me immensely if you use `git format-patch`, as that retains a bunch of metadata, including authorship so I don't have to remember to include that. ;)
Comment 3 Daniel Ebdrup Jensen freebsd_committer 2021-02-22 19:50:16 UTC
You're absolutely right, this _is_ a bug afterall.

As a tcsh user, I'm embarassed - my only excuse is that I use the tcsh runcom file at ~/.tcshrc.

I'll fix it post-haste. :)
Comment 4 commit-hook freebsd_committer 2021-02-22 19:56:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=1bc7558ecb04a88fbbc34ff0726f4b223f66e3ce

commit 1bc7558ecb04a88fbbc34ff0726f4b223f66e3ce
Author:     Ceri Davies <ceri@FreeBSD.org>
AuthorDate: 2021-02-22 19:51:25 +0000
Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
CommitDate: 2021-02-22 19:51:25 +0000

    handbook/l10n: Correct reference to csh login file

    The l10n chapter directs people to add things to ~/.csh.login but
    testing reveals that ~/.login is the right path.

    This has also been corroborated by dtrace, and the csh(1) manual page
    also refers to ~/.login.

    PR:             253758

 documentation/content/en/books/handbook/l10n/_index.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Daniel Ebdrup Jensen freebsd_committer 2021-02-22 19:57:22 UTC
Thank you for your extra attention to detail. ;)