Bug 253763 - www/gatling: Update to 0.16
Summary: www/gatling: Update to 0.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on: 253762 260184
Blocks:
  Show dependency treegraph
 
Reported: 2021-02-22 13:50 UTC by Fabian Keil
Modified: 2023-03-21 14:13 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (coco)


Attachments
www/gatling: Update to 0.16 (6.13 KB, patch)
2021-02-22 13:50 UTC, Fabian Keil
no flags Details | Diff
updated patch (5.83 KB, patch)
2023-02-20 18:15 UTC, Li-Wen Hsu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2021-02-22 13:50:52 UTC
Created attachment 222723 [details]
www/gatling: Update to 0.16

The attached patch updates gatling to 0.16.

- Change WWW and MASTER_SITES to https.
- Reorder variables to appease portclippy.
- Fix a couple of compiler warnings.
- Add a BROKEN_ITOJUN_V6 option (off by default) that works
  around problems binding to IPv4 addresses. Without it I get:
    
  # gatling -i 127.0.0.1
  socket_bind6_reuse: Can't assign requested address
    
  I tried to report this upstream but my mail was rejected ...
    
  The problem also presents with gatling 0.15.
    
This gatling update requires a libowfat update to 0.32 (PR #253762).
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-02-25 06:46:48 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A:
 /tmp/253763/www/gatling/files/patch-dl.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/253763/www/gatling/files/patch-gatling.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/253763/www/gatling/files/patch-GNUmakefile: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/253763/www/gatling/files/patch-smb.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html


Thanks!
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-08 19:15:39 UTC
(In reply to Fernando Apesteguía from comment #1)
Hello Frenando,

Can this port be assigned back to the pool? Maintainer timeout > 3 months
Comment 3 Marco Steinbach 2021-12-03 04:43:07 UTC
Hi there.

I ran into problems building gatling 0.16 with libowfat 0.32, with my own and Fabians patch and it would seem, that I am not the only one, as for example net/opentracker also breaks with libowfat 0.32. 

I've submitted a patch to devel/libowfat, see bug #260184 for more details, which unbreaks the build for me.
Comment 4 Fabian Keil 2021-12-03 08:30:19 UTC
(In reply to Marco Steinbach from comment #3)

That's interesting because I compile-tested net/opentracker before submitting the libowfat update in <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253762>.

At the time I was using an ElectroBSD amd64 system based on FreeBSD stable/11.

At the moment I'm using an ElectroBSD amd64 system based on FreeBSD stable/12 and I didn't notice any issues while building gatling 0.16, either.

Are you already using FreeBSD 13.x or 14.x?
Comment 5 Marco Steinbach 2021-12-03 12:27:23 UTC
(In reply to Fabian Keil from comment #4)

I am on 13, and I guess what I am seeing with devel/libowfat is a fallout of the upgraded llvm toolchain, namely this change: https://reviews.llvm.org/D75056
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2023-02-20 18:15:17 UTC
Created attachment 240292 [details]
updated patch

The rebase patch, please check.
Comment 7 Fabian Keil 2023-02-21 09:07:50 UTC
The rebased patch works for me on ElectroBSD 13.2-STABLE n254904-4f742fdf2283.

Thanks a lot.
Comment 8 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-03-21 14:03:32 UTC
This port is marked for deletion so take over and commit.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-03-21 14:11:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f11d9efc95a60cb990409f0ff25f51193c2d1d8a

commit f11d9efc95a60cb990409f0ff25f51193c2d1d8a
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2023-03-21 14:07:36 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-03-21 14:10:35 +0000

    www/gatling: Update version 0.15=>0.16

    - Update MASTER_SITES to https scheme
    - UNBREAK
    - Remove DEPRECATION
    - Utilize USES=localbase:lkdflags and refactor
    - Refactor ambiguous VARS like `bin` asnd `sbin`
    - Refactor make makepatch compatible patches
    - While I(bofh) am here pet portclippy/portfmt/OPTIONSNG

    PR:             253763

 www/gatling/Makefile                | 118 +++++++++++++++++-------------------
 www/gatling/distinfo                |   6 +-
 www/gatling/files/patch-GNUmakefile |  32 ++++++----
 www/gatling/files/patch-dl.c        |   6 +-
 www/gatling/files/patch-gatling.c   |   6 +-
 www/gatling/files/patch-smb.c       |   6 +-
 6 files changed, 87 insertions(+), 87 deletions(-)