Bug 253808 - net-p2p/xmrig FEATURE REQUEST please make port respect xmrig_flags in make.conf
Summary: net-p2p/xmrig FEATURE REQUEST please make port respect xmrig_flags in make.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-24 05:51 UTC by Patrick McMunn
Modified: 2021-02-24 22:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McMunn 2021-02-24 05:51:42 UTC 
Although xmrig has an xml file that can be edited to configure the program, command line flags are often simpler to configure the desired behavior. Please make the port respect xmrig_flags from /etc/make.conf.

For my own use, I have been editing /usr/local/etc/rc.d/xmrig to accomplish this behavior, but it's tedious to redo with every update to xmrig since it's updated so frequently. I've been simply changing the line

command_args="-f ${procname} --config=${xmrig_conf}"

to

command_args="-f ${procname} --config=${xmrig_conf} ${xmrig_flags}"

Please incorporate this change to the port.
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2021-02-24 05:54:37 UTC 
This port relies heavily on CPU optimizations. Without it it's basically useless.
Comment 2 Patrick McMunn 2021-02-24 05:56:58 UTC 
I meant from /etc/rc.conf -- not /etc/make.conf. In other words, runtime arguments -- not CPU optimizations during compilation.
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2021-02-24 06:06:49 UTC 
Ah, that makes sense.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-02-24 07:49:37 UTC 
A commit references this bug:

Author: ehaupt
Date: Wed Feb 24 07:49:21 UTC 2021
New revision: 566454
URL: https://svnweb.freebsd.org/changeset/ports/566454

Log:
  net-p2p/xmrig: Allow to set additional startup flags via xmrig_flags rc.subr

  PR:		253808
  Requested by:	Patrick McMunn <doctorwhoguy@gmail.com>

Changes:
  head/net-p2p/xmrig/Makefile
  head/net-p2p/xmrig/files/xmrig.in
Comment 5 Emanuel Haupt freebsd_committer freebsd_triage 2021-02-24 07:52:38 UTC 
Change implemented, thanks.
Comment 6 Patrick McMunn 2021-02-24 22:30:59 UTC 
Thank you!