Bug 253886 - www/firefox fix Mozilla bug 1694699 (regression causing losses of tabs in some situations)
Summary: www/firefox fix Mozilla bug 1694699 (regression causing losses of tabs in som...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Christoph Moench-Tegeder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-27 02:57 UTC by Graham Perrin
Modified: 2021-03-09 22:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-02-27 02:57:06 UTC 
<https://bugzilla.mozilla.org/show_bug.cgi?id=1694699#c24> refers to: 

<https://hg.mozilla.org/integration/autoland/rev/f6ee8b29a4cb>

> … Avoid unnecessary string->URI conversions r=rpl

<https://hg.mozilla.org/integration/autoland/rev/4d91456f4232>

> … Minimize access to tab.hasTabPermission r=rpl,geckoview-reviewers,agi 

– both with a milestone of 88.0a1. 

Please consider fixes for 1694699 amongst the next cherry-picks for 86.0. Thank you. 

Context
=======

Firefox 86: extension conflicts 
<https://www.reddit.com/r/firefox/comments/loptje/-/> 

– of the six or more extensions that appear to be in conflict with 
  Mozilla-recommended Simple Tab Groups, maybe most notable is the 
  Refined GitHub extension. 

Symptoms (oversimplified): loss of nearly all tabs from any group, if load of the group into a new window is followed by closure of the window.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2021-03-01 18:20:50 UTC 
<https://bugzilla.mozilla.org/show_bug.cgi?id=1694699#c26>

### Beta/Release Uplift Approval Request
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-03-09 09:59:15 UTC 
A commit references this bug:

Author: cmt
Date: Tue Mar  9 09:58:23 UTC 2021
New revision: 567916
URL: https://svnweb.freebsd.org/changeset/ports/567916

Log:
  firefox: import upstream bugfixes

  1 https://bugzilla.mozilla.org/show_bug.cgi?id=1694670
    "Linux startup crash in [@ qcms_data_create_rgb_with_gamma]"
    crash on startup when loading certain ICC profiles
  2 https://bugzilla.mozilla.org/show_bug.cgi?id=1694699
    "Investigate tabs API regression in Firefox 86"
    regression causing loss of tabs from tab groups

  PR:		253886 ([2])
  Reported by:	Hans Petter Selasky [1], Graham Perrin [2]
  MFH:		2021Q1

Changes:
  head/www/firefox/Makefile
  head/www/firefox/files/patch-bug1694670
  head/www/firefox/files/patch-bug1694699
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-09 10:00:15 UTC 
A commit references this bug:

Author: cmt
Date: Tue Mar  9 10:00:00 UTC 2021
New revision: 567917
URL: https://svnweb.freebsd.org/changeset/ports/567917

Log:
  MFH: r567916

  firefox: import upstream bugfixes

  1 https://bugzilla.mozilla.org/show_bug.cgi?id=1694670
    "Linux startup crash in [@ qcms_data_create_rgb_with_gamma]"
    crash on startup when loading certain ICC profiles
  2 https://bugzilla.mozilla.org/show_bug.cgi?id=1694699
    "Investigate tabs API regression in Firefox 86"
    regression causing loss of tabs from tab groups

  PR:		253886 ([2])
  Reported by:	Hans Petter Selasky [1], Graham Perrin [2]

Changes:
_U  branches/2021Q1/
  branches/2021Q1/www/firefox/Makefile
  branches/2021Q1/www/firefox/files/patch-bug1694670
  branches/2021Q1/www/firefox/files/patch-bug1694699
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2021-03-09 22:19:25 UTC 
(In reply to commit-hook from comment #2)

Fix confirmed; <https://bugzilla.mozilla.org/show_bug.cgi?id=1694699#c33>

Thank you 🏆