Created attachment 222876 [details] Patch for src/model.h adding sys/sysctl.h within the extern "C" block Doesn't compile on main 9995455218ff19df9cf0dcaf0198269dc76eeb2d with the ports tree at r566766: --- objectwindow.o --- In file included from ./src/objectwindow.cc:36: In file included from ./src/objectwindow.h:31: ./src/model.h:119:4: error: use of undeclared identifier 'CTLFLAG_RD' { CTLFLAG_RD, "RD", "Allow reads of variable", &m_col_RD, true}, ^ ./src/model.h:120:4: error: use of undeclared identifier 'CTLFLAG_WR' { CTLFLAG_WR, "WR", "Allow writes to the variable", &m_col_WR, true}, ^ ./src/model.h:121:4: error: use of undeclared identifier 'CTLFLAG_RW' { CTLFLAG_RW, "RW", "RD and WR", &m_col_RW, false}, ^ ./src/model.h:122:4: error: use of undeclared identifier 'CTLFLAG_ANYBODY' { CTLFLAG_ANYBODY, "ANYBODY", "All users can set this var", &m_col_ANYBODY, true}, ^ ./src/model.h:123:4: error: use of undeclared identifier 'CTLFLAG_TUN' { CTLFLAG_TUN, "TUN", "Default value is loaded from getenv()", &m_col_TUN, true }, ^ ./src/model.h:124:4: error: use of undeclared identifier 'CTLFLAG_RDTUN' { CTLFLAG_RDTUN, "RDTUN", "RD and TUN", &m_col_RDTUN, false}, ^ ./src/model.h:125:4: error: use of undeclared identifier 'CTLFLAG_RWTUN' { CTLFLAG_RWTUN, "RWTUN", "RW and TUN", &m_col_RWTUN, false}, ^ ./src/model.h:126:4: error: use of undeclared identifier 'CTLFLAG_STATS' { CTLFLAG_STATS, "STATS", "Statistics, not a tuneable", &m_col_STATS, true}, ^ ./src/model.h:127:4: error: use of undeclared identifier 'CTLFLAG_NOFETCH' { CTLFLAG_NOFETCH, "NOFETCH", "Don't fetch tunable from getenv()", &m_col_NOFETCH, true}, ^ ./src/model.h:128:4: error: use of undeclared identifier 'CTLFLAG_CAPRD' { CTLFLAG_CAPRD, "CAPRD", "Can be read in capability mode", &m_col_CAPRD, true}, ^ ./src/model.h:129:4: error: use of undeclared identifier 'CTLFLAG_CAPWR' { CTLFLAG_CAPWR, "CAPWR", "Can be written in capability mode", &m_col_CAPWR, true}, ^ ./src/model.h:130:4: error: use of undeclared identifier 'CTLFLAG_CAPRW' { CTLFLAG_CAPRW, "CAPRW", "CAPRD and CAPWR", &m_col_CAPRW, false}, ^ ./src/model.h:131:4: error: use of undeclared identifier 'CTLFLAG_SECURE' { CTLFLAG_SECURE, "SECURE", "Permit set only if securelevel<=0", &m_col_SECURE, true}, ^ ./src/model.h:132:4: error: use of undeclared identifier 'CTLMASK_SECURE' { CTLMASK_SECURE, "MASKSECURE", "Secure level", &m_col_CTLMASK_SECURE, true}, ^ ./src/model.h:133:4: error: use of undeclared identifier 'CTLFLAG_PRISON' { CTLFLAG_PRISON, "PRISON", "Prisoned roots can fiddle", &m_col_PRISON, true}, ^ ./src/model.h:134:4: error: use of undeclared identifier 'CTLFLAG_VNET' { CTLFLAG_VNET, "VNET", "Prisons with vnet can fiddle", &m_col_VNET, true}, ^ ./src/model.h:135:4: error: use of undeclared identifier 'CTLFLAG_MPSAFE' { CTLFLAG_MPSAFE, "MPSAFE", "Handler is MP safe", &m_col_MPSAFE, true}, ^ ./src/model.h:138:4: error: use of undeclared identifier 'CTLFLAG_DYN' { CTLFLAG_DYN, "DYN", "Dynamic oid (can be freed)", &m_col_DYN, true}, ^ ./src/model.h:139:4: error: use of undeclared identifier 'CTLFLAG_DYING' { CTLFLAG_DYING, "DYING", "Oid is being removed", &m_col_DYING, false}, ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. *** [objectwindow.o] Error code 1
I added a PR with a similar patch yesterday, and it should be committed: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253884 However, it does not seem to exist in: https://svnweb.freebsd.org/ports/head/deskutils/sysctlview/ Instead the Portrevision was added
And for the same library PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253883 please add a Portrevision to audio/mixertui
Created attachment 222891 [details] svn .diff with new Portrevision Patch with new Portevision
Committed!
A commit references this bug: Author: nc Date: Mon Mar 1 01:54:26 UTC 2021 New revision: 566825 URL: https://svnweb.freebsd.org/changeset/ports/566825 Log: deskutils/sysctlview: Add missing include to sys/sysctl.h PR: 253910 Submitted by: Trond.Endrestol AT ximalas DOT info Approved by: alfix86 AT gmail DOT com (maintainer) Changes: head/deskutils/sysctlview/Makefile head/deskutils/sysctlview/files/ head/deskutils/sysctlview/files/patch-src_model.h