Bug 253930 - devel/lua-sysctl: fix module loading on lua 5.3+
Summary: devel/lua-sysctl: fix module loading on lua 5.3+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-01 07:19 UTC by Oleksii Samorukov
Modified: 2021-03-01 08:01 UTC (History)
1 user (show)

See Also:
uzsolt: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksii Samorukov freebsd_committer 2021-03-01 07:19:12 UTC
I found that devel/lua-sysctl is broken on lua 5.3+.

Reason is usage of `lua_pushunsigned` which was removed later, it actually prints warning about it during compilation and triggers error (unresolved syntax) on load.
Comment 2 Oleksii Samorukov freebsd_committer 2021-03-01 07:23:23 UTC
uzsolt@uzsolt.hu please approve changes.
Comment 3 commit-hook freebsd_committer 2021-03-01 07:58:24 UTC
A commit references this bug:

Author: samm
Date: Mon Mar  1 07:57:51 UTC 2021
New revision: 566833
URL: https://svnweb.freebsd.org/changeset/ports/566833

Log:
  devel/lua-sysctl: fix module loading on lua 5.3+

  PR:		253930
  Approved by:	uzsolt@uzsolt.hu (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D28992

Changes:
  head/devel/lua-sysctl/Makefile
  head/devel/lua-sysctl/files/
  head/devel/lua-sysctl/files/patch-src_lua__sysctl.c