Bug 253945 - devel/upnp: Update to 1.14.2, take maintainership
Summary: devel/upnp: Update to 1.14.2, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-03-01 20:43 UTC by Dries Michiels
Modified: 2021-03-01 21:34 UTC (History)
1 user (show)

See Also:


Attachments
upnp.diff (5.11 KB, patch)
2021-03-01 20:44 UTC, Dries Michiels
no flags Details | Diff
upnp.diff (5.18 KB, patch)
2021-03-01 20:48 UTC, Dries Michiels
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:43:33 UTC
Poudriere testport looks good. Its possible some ports need a portrevision bump given the shared lib has been bumped in this revision. I ran the script under Tol
ols/script/search_lib_depends_and_bump.sh but didn't find any port so should be OK.
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:44:41 UTC
Created attachment 222909 [details]
upnp.diff

upnp.diff
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:48:55 UTC
Created attachment 222910 [details]
upnp.diff

fold in some changes suggested by portclippy.
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:52:49 UTC
I was lying about the dependent ports:

find . -name Makefile -exec grep -l "devel/upnp" {} \;
./net/gerbera/Makefile
./devel/upnp/Makefile
./multimedia/vlc/Makefile
./net-p2p/amule-devel/Makefile
./net-p2p/amule/Makefile
Comment 4 Automation User 2021-03-01 20:54:21 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/263698138
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:54:57 UTC
Although after scanning each of the makefiles of those ports it seems that devel/upnp is not a standard dependency (always an option) => Do we still need to bump portrevision in that case?
Comment 6 Neel Chauhan freebsd_committer freebsd_triage 2021-03-01 21:34:37 UTC
Committed!
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-03-01 21:34:47 UTC
A commit references this bug:

Author: nc
Date: Mon Mar  1 21:34:28 UTC 2021
New revision: 566912
URL: https://svnweb.freebsd.org/changeset/ports/566912

Log:
  devel/upnp: Update to 1.14.2 and pass maintainership to submitter

  PR:		253945
  Submitted by:	Dries Michiels <driesm.michiels AT gmail DOT com>

Changes:
  head/devel/upnp/Makefile
  head/devel/upnp/distinfo
  head/devel/upnp/files/patch-upnp_src_genlib_net_http_httpreadwrite.c
  head/devel/upnp/pkg-plist