Bug 253949 - cgit implies commit touches file when it doesn't
Summary: cgit implies commit touches file when it doesn't
Status: In Progress
Alias: None
Product: Services
Classification: Unclassified
Component: Git Integration (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Some People
Assignee: Ulrich Spörlein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-01 22:41 UTC by John-Mark Gurney
Modified: 2021-03-20 02:06 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John-Mark Gurney freebsd_committer 2021-03-01 22:41:41 UTC
If you navigate to a file, such as:
https://cgit.freebsd.org/src/tree/lib/libc/amd64/string/strlen.S

And then click on commit, to get the latest commit for that file:
https://cgit.freebsd.org/src/commit/lib/libc/amd64/string/strlen.S

Instead of showing the latest commit for that file, it shows you the latest commit for the entire tree.  This is quite surprising, and not clear that is what happens.
Comment 1 Ulrich Spörlein freebsd_committer 2021-03-02 10:12:55 UTC
You probably have to take this up with the cgit folks.

The tree view always browses at head (as you can see by not having a hash in the URL) and the commit view also browses at head (I didn't know you could give it a path).

cgit URLs are wonky and it's not a terribly good UI that you can click on the various tabs and have partial stuff (like the path) transferred.

Anyway, this is not something we can or will likely fix. Maybe browsing via the GitHub or Gitlab UI is better? There are also tools like gitk (or tig or whatever) for your local browsing needs.

IOW, what is the actual information you're looking at? Did you maybe want to go from https://cgit.freebsd.org/src/tree/lib/libc/amd64/string/strlen.S to the "blame" view?