Bug 254011 - graphics/rawstudio: Add missing dependencies
Summary: graphics/rawstudio: Add missing dependencies
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-04 16:17 UTC by Rainer Hurling
Modified: 2021-04-09 19:56 UTC (History)
2 users (show)

See Also:
samm: maintainer-feedback+


Attachments
patch to add missing dependencies and reorder some Makefile vars (1.40 KB, patch)
2021-03-04 16:17 UTC, Rainer Hurling
rhurlin: maintainer-approval? (samm)
Details | Diff
patch with added NLS option and renewed patch files (18.35 KB, patch)
2021-03-06 19:47 UTC, Rainer Hurling
rhurlin: maintainer-approval? (samm)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer 2021-03-04 16:17:22 UTC
Created attachment 222977 [details]
patch to add missing dependencies and reorder some Makefile vars

Thanks for the ports update. Really appreciated.

While building your updated port v2.0, some errors occur in the Q/A tests, if DEVELOPERS=yes is set in /etc/make.conf:


====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency
Warning: you need USE_GNOME+=cairo
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency
Warning: you need USE_GNOME+=gdkpixbuf2
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libcurl.so.4 from ftp/curl but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libcurl.so:ftp/curl
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libraptor2.so.0 from textproc/raptor2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libraptor2.so:textproc/raptor2
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libX11.so.6 from x11/libX11 but it is not declared as a dependency
Warning: you need USE_XORG+=x11
Error: /usr/local/bin/rawstudio is linked to /usr/local/lib/libtiff.so.5 from graphics/tiff but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libtiff.so:graphics/tiff
Warning: /usr/ports/graphics/rawstudio/work/stage/usr/local/lib/librawstudio-2.0.so.0.0.0 doesn't have a SONAME.
Warning: pkg(8) will not register it as being provided by the port.
Warning: If another port depend on it, pkg will not be able to know where it comes from.
Warning: It is directly in /usr/local/lib, it is probably used by other ports.
===>  Installing for rawstudio-2.0_19
===>  Checking if rawstudio is already installed
===>   Registering installation for rawstudio-2.0_19
Installing rawstudio-2.0_19...


Attached you will find a patch, which adds the dependencies in question. It builds and installs fine with them. While here, I also ordered some Makefile vars, like suggested by portclippy.

If you agree, I would like to commit this patch :)
Comment 1 Bugzilla Automation freebsd_committer 2021-03-04 16:17:22 UTC
Maintainer informed via mail
Comment 2 Oleksii Samorukov freebsd_committer 2021-03-06 07:57:09 UTC
Thank you for handling that, looks good :) 

If it is passing poudriere - lgtm.
Comment 3 Rainer Hurling freebsd_committer 2021-03-06 19:47:08 UTC
Created attachment 223032 [details]
patch with added NLS option and renewed patch files

Hi Oleksii,

When retesting before committing, I stumbled across two more issues that I had previously overlooked and tried to solve now:

(1) 'portlint -AC' warns:
Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.

I added NLS option, enabled by default.


(2) More warnings from 'portlint -AC':
WARN: /usr/home/rhurlin/svn/ports_rawstudio/graphics/rawstudio/files/patch-exiv2: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /usr/home/rhurlin/svn/ports_rawstudio/graphics/rawstudio/files/patch-libpng15: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /usr/home/rhurlin/svn/ports_rawstudio/graphics/rawstudio/files/patch-rs-macros.h: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /usr/home/rhurlin/svn/ports_rawstudio/graphics/rawstudio/files/patch-rs-tag-gui.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /usr/home/rhurlin/svn/ports_rawstudio/graphics/rawstudio/files/patch-libpng15: plugins/load-gdk/exiv2-colorspace.cpp patched multiple times
0 fatal errors and 7 warnings found.

For this I renewed and rearranged all patches under files. 

It would probably also make sense to change the two REINPLACE_CMDs in the post-patch target to patchfiles. However, I have not done that.


I tested these changes on Poudriere and all build and install fine.

If you agree with the new patch, could you please check, if it runs as expected and do some tests before I commit?
Comment 4 Rainer Hurling freebsd_committer 2021-04-09 19:56:53 UTC
(In reply to Rainer Hurling from comment #3)

Hi Oleksii,

Just to be sure: Do you agree with my updated patch, as mentioned in comment #3?

If yes, I would like to commit it.