Bug 254038 - www/py-pyjwt: Update to 2.1.0
Summary: www/py-pyjwt: Update to 2.1.0
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://github.com/jpadilla/pyjwt/blo...
Keywords: buildisok
Depends on:
Blocks: 254039 257369
  Show dependency treegraph
Reported: 2021-03-05 15:22 UTC by Goran Mekić
Modified: 2021-07-24 00:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (terje)

pyjwt.diff (814 bytes, patch)
2021-03-05 15:22 UTC, Goran Mekić
no flags Details | Diff
pyjwt1.diff (12.28 KB, patch)
2021-06-11 11:58 UTC, Goran Mekić
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2021-03-05 15:22:03 UTC
Created attachment 223004 [details]


  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 12.2, amd64 tested)
  * maketest: OK (173 passed, 1 skipped, 1 xfailed)
Comment 1 Automation User 2021-03-05 15:40:41 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/266092718
Comment 2 Rainer Hurling freebsd_committer 2021-03-07 06:45:56 UTC
Hi Goran, hi Terje,

As far as I can say until now, this update also needs an update of devel/py-msal and sysutils/conan. Both give same type of error:

py37-msal-1.9.0 depends on package: py37-pyjwt>=1.0.0<2 - not found
conan-1.34.0 depends on package: py37-pyjwt>=1.4.0,<2.0.0 - not found

Could you investigate into them, please?

Another issue: The changelog for www/py-pyjwt says cryptography >= 3 is needed. For now, we do not have cryptography-3.x in the ports, because of some trouble with OpenSSL. Did you try, if cryptography-2.x also works?
Comment 3 Goran Mekić 2021-03-07 09:18:32 UTC
I will check depending ports. For cryptography, 3.3 is already in ports: https://www.freshports.org/security/py-cryptography/
Comment 4 Goran Mekić 2021-03-07 09:29:53 UTC
While msal is OK with newer JWT (https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/setup.py#L76), conan isn't (https://github.com/conan-io/conan/blob/develop/conans/requirements.txt#L1). I'll talk to upstream about it.
Comment 5 Rainer Hurling freebsd_committer 2021-03-07 09:55:04 UTC
(In reply to Goran Mekić from comment #3)

Oops, you are right. I must have looked into one of my older svn repos ;)
Comment 6 Goran Mekić 2021-03-09 16:07:30 UTC
Conan upstream ticket: https://github.com/conan-io/conan/issues/8609

What is the best course of action? Having pyjwt1 and pyjwt in ports?
Comment 7 Rainer Hurling freebsd_committer 2021-03-09 16:28:11 UTC
(In reply to Goran Mekić from comment #6)

> What is the best course of action? Having pyjwt1 and pyjwt in ports?
Hmm, I really don't know because I don't work with any of those ports.

If you can't wait to update www/py-pyjwt because you need the www/py-flask-jwt-extended update, it's probably best to have an old port and a current port for www/py-pyjwt. Renaming the old one to something like www/py-pyjwt1 seems plausible to me in this case.

If you are not in a hurry, you could wait until conan has updated its dependencies upstream ...

Have you already had contact with the maintainer of www/py-pyjwt?
Comment 8 Goran Mekić 2021-06-11 11:58:19 UTC
Created attachment 225729 [details]

I ran "make -DBATCH test clean" on all ports I changed dependency for. This patch adds pyjwt1 port and upgrades current one to 2.1.0. I am currently running poudriere bulk on those ports on https://pkg.tilda.center/build.html?mastername=FreeBSD%3A13%3Aamd64-local&build=2021-06-11_13h51m10s and as I see LLVM in the build queue, it will take a while.
Comment 9 Goran Mekić 2021-06-11 12:11:17 UTC
Sorry, forgot to switch the branch on the build server, so I had to restart the build: https://pkg.tilda.center/build.html?mastername=FreeBSD%3A13%3Aamd64-local&build=2021-06-11_14h10m11s
Comment 10 Goran Mekić 2021-06-14 10:15:51 UTC
Poudriere was successfull. All packages were in there except flask-jwt-extended because that one will be updated to use pyjwt 2.x.
Comment 11 Goran Mekić 2021-06-24 11:10:50 UTC
What's our next move?