Bug 254187 - net/kamailio: Update to 5.4.4
Summary: net/kamailio: Update to 5.4.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lewis Cook
URL: https://www.kamailio.org/pub/kamailio...
Depends on:
Reported: 2021-03-10 12:53 UTC by Dmitry Wagin
Modified: 2021-03-10 21:25 UTC (History)
1 user (show)

See Also:

kamailio.diff (946 bytes, patch)
2021-03-10 12:53 UTC, Dmitry Wagin
dmitry.wagin: maintainer-approval+
Details | Diff
D29188.diff (5.29 KB, patch)
2021-03-10 15:55 UTC, Lewis Cook
lcook: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2021-03-10 12:53:50 UTC
Created attachment 223150 [details]

Update to 5.4.4
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2021-03-10 15:55:37 UTC
Created attachment 223160 [details]

Hi Dmitry,

I've attached an updated patch that addresses suggestions by portclippy[1], there were a few nit-picks as-well-as a general cleanup of the option helpers. If you're happy, I'll include these changes in the commit. 

[1] Please do feel free to check out portfmt tools if you haven't already (https://www.freshports.org/ports-mgmt/portfmt). :-)

Comment 2 Dmitry Wagin 2021-03-10 16:07:57 UTC
(In reply to Lewis Cook from comment #1)
Patch looks nice, only the order of the lines has changed?
Comment 3 Lewis Cook freebsd_committer freebsd_triage 2021-03-10 16:12:24 UTC
(In reply to Dmitry Wagin from comment #2)
Basically, yeah. Just a trivial clean-up on my behalf with using portclippy/portfmt. :-)
Comment 4 Dmitry Wagin 2021-03-10 16:15:43 UTC
(In reply to Lewis Cook from comment #3)
poudriere testport = ok

thank you for portclippy/portfmt ;-)
Comment 5 Dmitry Wagin 2021-03-10 16:18:38 UTC
lcook: maintainer-approval?

for some reason it doesn't change...
Comment 6 Lewis Cook freebsd_committer freebsd_triage 2021-03-10 17:05:31 UTC
(In reply to Dmitry Wagin from comment #5)
No worries, I'll commit this soon. Just waiting on a review at the moment :)
Comment 7 commit-hook freebsd_committer 2021-03-10 21:24:39 UTC
A commit references this bug:

Author: lcook
Date: Wed Mar 10 21:24:33 UTC 2021
New revision: 568045
URL: https://svnweb.freebsd.org/changeset/ports/568045

  net/kamailio: Update to 5.4.4

  While here, appease portclippy and portfmt.

  Changes: 		https://www.kamailio.org/pub/kamailio/5.4.4/ChangeLog
  PR: 			254187
  Submitted by: 		Dmitry Wagin <dmitry.wagin@ya.ru> (maintainer)
  Approved by:		fernape (mentor)
  Differential Revision:	https://reviews.freebsd.org/D29188

Comment 8 Lewis Cook freebsd_committer freebsd_triage 2021-03-10 21:25:44 UTC
Committed, thanks!