Bug 254264 - x11-wm/hikari: drop unused dependencies
Summary: x11-wm/hikari: drop unused dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-03-14 00:14 UTC by Jan Beich
Modified: 2021-03-16 17:09 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+


Attachments
v1 (955 bytes, patch)
2021-03-14 00:14 UTC, Jan Beich
no flags Details | Diff
poudriere testport (102.06 KB, text/plain)
2021-03-14 00:15 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-03-14 00:14:20 UTC
Created attachment 223243 [details]
v1

- libepoll-shim is used by libwayland-server instead
- glib20 is implicitly added by pango and only used to free pango stuff
Comment 1 Jan Beich freebsd_committer 2021-03-14 00:15:24 UTC
Created attachment 223244 [details]
poudriere testport
Comment 2 Li-Wen Hsu freebsd_committer 2021-03-14 09:57:38 UTC
Submitter is committer
Comment 3 Alexander Sieg 2021-03-14 17:15:13 UTC
lgtm.

Is there some tooling to detect such unneeded dependencies?
Comment 4 commit-hook freebsd_committer 2021-03-16 16:35:42 UTC
A commit references this bug:

Author: jbeich
Date: Tue Mar 16 16:35:28 UTC 2021
New revision: 568580
URL: https://svnweb.freebsd.org/changeset/ports/568580

Log:
  x11-wm/hikari: drop unused dependencies

  - libepoll-shim is used by graphics/wayland instead
  - glib20 is auto-added via USE_GNOME due to being part of pango API

  PR:		254264
  Approved by:	Alexander Sieg (maintainer)

Changes:
  head/x11-wm/hikari/Makefile
Comment 5 Jan Beich freebsd_committer 2021-03-16 17:09:13 UTC
(In reply to Alexander Sieg from comment #3)
> Is there some tooling to detect such unneeded dependencies?

I don't think so, only noticed during devel/libepoll-shim update when testing consumers. One can compare NEEDED lines in poudriere logs, enable DEVELOPER=1 then re-populate deps from scratch and check LDFLAGS+=-Wl,--as-needed impact.