Bug 254322 - devel/gvfs: should depend on sysutils/lsof
Summary: devel/gvfs: should depend on sysutils/lsof
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-16 01:29 UTC by Damjan Jovanovic
Modified: 2021-03-16 10:43 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Damjan Jovanovic 2021-03-16 01:29:11 UTC
When a drive can't be unmounted and returns EBUSY, gvfs calls "lsof -t /mountpoint" to find which processes have files open. This list is sent over the "show-processes" signal, which allows file managers to show which apps are preventing the unmount.

For this to work, sysutils/lsof needs to be around. The port should depend on it at runtime, ie. something along these lines:

--------
diff --git a/devel/gvfs/Makefile b/devel/gvfs/Makefile
index 830823c13ecc..aad75271e9c1 100644
--- a/devel/gvfs/Makefile
+++ b/devel/gvfs/Makefile
@@ -23,7 +23,8 @@ LIB_DEPENDS=  libgcrypt.so:security/libgcrypt \
                libudisks2.so:sysutils/libudisks \
                libsecret-1.so:security/libsecret
                
-RUN_DEPENDS=       bsdisks>0:sysutils/bsdisks
+RUN_DEPENDS= bsdisks>0:sysutils/bsdisks \
+         lsof:sysutils/lsof
 PORTSCOUT=     limitw:1,even
 
 USES=          gettext gnome libarchive localbase meson \
--------
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2021-03-16 10:43:03 UTC
^Triage: give this a correct Summary and assign.