Bug 254353 - www/webkit2-gtk3: fix build with newer dependencies
Summary: www/webkit2-gtk3: fix build with newer dependencies
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-03-16 20:50 UTC by Evgeniy Khramtsov
Modified: 2021-05-01 10:41 UTC (History)
2 users (show)

See Also:
evgeniy: maintainer-feedback-


Attachments
patch (4.17 KB, patch)
2021-03-16 20:50 UTC, Evgeniy Khramtsov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Khramtsov 2021-03-16 20:50:27 UTC
Created attachment 223345 [details]
patch

See 254350-254352

Some changes related to gstreamer (discussed in FreeBSDDesktop Gitter) were left out due to issues with YouTube playback under sway and GDK_BACKEND=x11. The issues are not related to the patches, as they are reproducable with all vanilla packages from pkg.FreeBSD.org.

Removed patch that contained xlib related define because it is no longer needed.

make makepatch changed some patch.
Comment 1 Evgeniy Khramtsov 2021-04-23 21:14:12 UTC
See 254351, 254352. Unfortunately, I didn't pay attention to the order of submitted changes this time. I think committing these two PR and this in a single commit may be fine. Maintainer timeout.
Comment 2 Jan Beich freebsd_committer 2021-05-01 02:34:50 UTC
Hmm, I can't reproduce despite but it was upstreamed in https://github.com/WebKit/WebKit/commit/e9fd543c8de4072955df40e5aaa9139cca19acba
Comment 3 Evgeniy Khramtsov 2021-05-01 10:41:02 UTC
(In reply to Jan Beich from comment #2)

www/wpebackend-fdo is now at recent and not known to be vulnerable version,
thanks.

I might have stumbled upon this issue due to an older version of webkit, or
some local nox11 options/patches. This may not be reproducible on vanilla ports,
I guess. Good to know that the wpe include part is now upstream. This bug can be closed.

Repology reports that the latest version of this port is 2.32, though updating
webkit is not on my todo, maybe gnome@ has it on their todo.