Bug 254358 - rc.conf.5: Document firewall_type "workstation"
Summary: rc.conf.5: Document firewall_type "workstation"
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Ebdrup Jensen
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-03-17 09:10 UTC by Tobias Rehbein
Modified: 2021-03-18 17:41 UTC (History)
2 users (show)

See Also:

Attachments
Patch for rc.conf.5 (863 bytes, patch)
2021-03-17 09:10 UTC, Tobias Rehbein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Rehbein 2021-03-17 09:10:00 UTC 
Created attachment 223355 [details]
Patch for rc.conf.5

* Document "workstation" as a firewall_type value
* Add a note about additional configuration variables for predefined rulesets

Note: The note about additional configuration variables is a poor mans solution for bug #127359. It's not perfect, but probably better than nothing.
Comment 1 Daniel Ebdrup Jensen freebsd_committer freebsd_triage 2021-03-18 13:43:42 UTC 
I'll take this.

Are you okay with being credited using `git commit --author"Tobias Rehbein <tobias.rehbein@web.de>" ?
Comment 2 Tobias Rehbein 2021-03-18 15:16:17 UTC 
(In reply to Daniel Ebdrup Jensen from comment #1)
Sure, thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-18 17:40:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c39dda81923a26116241fbe996351133c86ad97a

commit c39dda81923a26116241fbe996351133c86ad97a
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2021-03-18 17:01:09 +0000
Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
CommitDate: 2021-03-18 17:39:24 +0000

    rc.conf(5): Document the 'workstation' firewall_type

    Document the workstation ACL ruleset, which uses stateful rules.

    While here, add a note about where some of the undocumented variables
    can be found. This is not a perfect solution for bug 127359, but it at
    at least gives a place to go look, and can be used as a reference for
    when bug 127359 gets fixed properly.

    PR:             254358, 127359

 share/man/man5/rc.conf.5 | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Comment 4 Daniel Ebdrup Jensen freebsd_committer freebsd_triage 2021-03-18 17:41:43 UTC 
Thank you for your attention to detail. :)