Bug 254385 - fix assorted bugs in emulators/qemu
Summary: fix assorted bugs in emulators/qemu
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-18 17:24 UTC by Piotr Pawel Stefaniak
Modified: 2021-04-20 20:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments
fix assorted bugs in emulators/qemu (1.90 KB, patch)
2021-03-18 17:24 UTC, Piotr Pawel Stefaniak
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Pawel Stefaniak freebsd_committer freebsd_triage 2021-03-18 17:24:57 UTC
Created attachment 223396 [details]
fix assorted bugs in emulators/qemu

bin/elf2dmp apparently depends on CURL
actually reduce build to only X86 architectures if X86_TARGETS is set
I don't think that rx is an X86 architecture, so don't try to install it
building manual pages is optional and pkg-plist should reflect that
DOCS_BUILD_DEPENDS includes sphinx so there's no need for it in BUILD_DEPENDS
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2021-04-11 19:50:32 UTC
manual pages are not optional. Irrespective of DOCS on or off we should build man pages unless there is a very large number of man pages which itself we want to put on OPTIONS hence we need the sphinx dependency.

I will fix elf2dmp with build time fix on 13 and head.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-04-20 19:47:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e06cd0454806020fc8e2f11df85baf500690902

commit 9e06cd0454806020fc8e2f11df85baf500690902
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2021-04-20 19:41:51 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2021-04-20 19:46:11 +0000

    emulators/qemu: Fix build on 13

    - Use ports dtc instead of packaged dtc [1]
    - bin/elf2dmp apparently depends on CURL [2]
    - Reduce build to only X86 architectures if X86_TARGETS is set [2]
    - rx is not an X86 architecture [2]

    PR:             245997 [1] 254385 [2]
    Reported by:    swills [1] pstef [2]

 emulators/qemu/Makefile  | 13 +++++++++++--
 emulators/qemu/pkg-plist |  6 ++++--
 2 files changed, 15 insertions(+), 4 deletions(-)