Bug 254425 - sysutils/angrysearch: Check for py-sqlite3 via PYTHON_PKGNAMEPREFIX
Summary: sysutils/angrysearch: Check for py-sqlite3 via PYTHON_PKGNAMEPREFIX
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks: 253815
  Show dependency treegraph
 
Reported: 2021-03-20 09:07 UTC by Kai Knoblich
Modified: 2021-03-21 08:54 UTC (History)
1 user (show)

See Also:
danfe: maintainer-feedback+


Attachments
angrysearch-fix-packaging-with-py38.patch (472 bytes, patch)
2021-03-20 09:07 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2021-03-20 09:07:51 UTC
Created attachment 223443 [details]
angrysearch-fix-packaging-with-py38.patch

Hi Alexey,

the exp-run (PR #253815) revealed that the port sysutils/angrysearch fails in the run-depends phase with PYTHON3_DEFAULT=3.8:

> ===>   angrysearch-1.0.2_5 depends on file: /usr/local/lib/python3.8/lib-dynload/_sqlite3.so - not found
> *** Error code 1

This is because since Python 3.8.7 the "_sqlite3.so" file got an extension added and is now named "_sqlite3.cpython-38.so".

Attached is a patch that fixes the above mentioned issue by checking for the presence of the py38-sqlite3 package instead of the actual .so file itself as it's done in many other ports.

QA:
~~~
- poudriere -> OK (12.2-RELEASE amd64 with PYTHON3_DEFAULT=3.7)
- poudriere -> OK (12.2-RELEASE amd64 with PYTHON3_DEFAULT=3.8)
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-03-20 09:21:00 UTC
Sure, go ahead!
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2021-03-21 08:53:24 UTC
Comment on attachment 223443 [details]
angrysearch-fix-packaging-with-py38.patch

^ Triage: Set maintainer-approval flag to '+' as the approval was given in comment #1.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-21 08:53:52 UTC
A commit references this bug:

Author: kai
Date: Sun Mar 21 08:53:36 UTC 2021
New revision: 568909
URL: https://svnweb.freebsd.org/changeset/ports/568909

Log:
  sysutils/angrysearch: Adjust RUN_DEPENDS for Python 3.8.7 and onward

  * Since Python 3.8.7 (and also 3.9.2), .so files get an extension, e.g.
    ".cpython-38.so" if built with Python 3.8.

    Thus check for the presence of the package from databases/py-sqlite3
    instead of the actual .so file itself.

  PR:		254425
  Approved by:	danfe (maintainer)

Changes:
  head/sysutils/angrysearch/Makefile
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2021-03-21 08:54:46 UTC
(In reply to Alexey Dokuchaev from comment #1)

Committed, thank you for the review and approval!