Created attachment 223576 [details]
Tested in poudriere with various OPTIONs set.
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/276507464
I few issues that should be fixed in general
PORTVERSION --> DISTVERSION
"Table 5.2. Package Naming Examples" in Porters Handbook
MASTER_SITES --> https (redirects to https)
This also applies to pkg-descr
Upstream provides a bz2 archive (smaller in size)
Should we perhaps use C++14 instead of 11?
Created attachment 223666 [details]
Thanks for the review, Daniel! I've applied all your suggestions.
Thanks, you forgot switching to tar.bz2 archive it seems?
The patch looks good to me. I've run it on poudriere for 11 & 12 and it works fine.
There's a minor issue: you added an extra space while replacing CMAKE_DEBUG_POSTFIX, which I think is not needed.
A commit references this bug:
Date: Mon Mar 29 16:14:18 UTC 2021
New revision: 569479
devel/poco: Update to 1.10.1
Reviewed by: firstname.lastname@example.org
Approved by: Henry Hu <email@example.com>
I have incorporated bz2 and sed suggestions and committed the update. Thanks everyone.