Bug 254653 - net/pacemaker1: Config option DBUS off does not affect.
Summary: net/pacemaker1: Config option DBUS off does not affect.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vinícius Zavam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-30 04:06 UTC by radi-sh
Modified: 2021-05-06 23:59 UTC (History)
0 users

See Also:
egypcio: maintainer-feedback+


Attachments
net/pacemaker1: fix the use of REPLACE_ARGS and REPLACE_ARGS_OCF (1.48 KB, patch)
2021-04-22 19:05 UTC, Vinícius Zavam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description radi-sh 2021-03-30 04:06:36 UTC
net/pacemaker2 too.
Maybe typo in Makefile.common .

-DBUS_VARS_OFF= REPLACE_ARGS+="-e 's/HAVE_dbus=1/HAVE_dbus=0/'"
+DBUS_VARS_OFF= REPLACE_ARGS_OCF+="-e 's/HAVE_dbus=1/HAVE_dbus=0/'"
Comment 1 Vinícius Zavam freebsd_committer 2021-04-14 08:01:33 UTC
hello there! hi,
thanks for already sharing a patch for that. appreciated :)

I should take time this week to get it a try and get back to the PR. []
Comment 2 Vinícius Zavam freebsd_committer 2021-04-22 19:05:04 UTC
Created attachment 224361 [details]
net/pacemaker1: fix the use of REPLACE_ARGS and REPLACE_ARGS_OCF

I'm attaching here a patch file which I do plan to commit; there are still a few testing scenarios to be checked before it hits our tree.

- we are having issues on 13.0 with this one.

would you mind to check on your side as well?
Comment 3 radi-sh 2021-04-23 05:28:00 UTC
It's fine in test building.
Comment 4 commit-hook freebsd_committer 2021-05-06 23:57:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=73059f063ec124bb34540a609f7b6306045e9bd0

commit 73059f063ec124bb34540a609f7b6306045e9bd0
Author:     Vinícius Zavam <egypcio@FreeBSD.org>
AuthorDate: 2021-05-06 23:50:05 +0000
Commit:     Vinícius Zavam <egypcio@FreeBSD.org>
CommitDate: 2021-05-06 23:50:05 +0000

    net/pacemaker1: fix DBUS config option, and its REINPLACE_ARGS

      - 'post-patch-common' never used was DBUS_VARS_OFF really set;
      - REPLACE_ARGS renamed to REPLACE_CMD_ARGS;
      - REPLACE_ARGS_OCF and REPLACE_ARGS_DBUS append into REPLACE_ARGS.

      while here,

        * mark port as broken if OSVERSION>=1300000

    PR:             254653
    Reported by:    masamory7 % gmail.com

 net/pacemaker1/Makefile        |  5 +++++
 net/pacemaker1/Makefile.common | 10 +++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)