Bug 254688 - [REVIVE] www/sws
Summary: [REVIVE] www/sws
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Renato Botelho
URL:
Keywords: easy, needs-patch
Depends on:
Blocks:
 
Reported: 2021-04-01 05:44 UTC by Brett Wynkoop
Modified: 2023-11-29 18:59 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (bsdbugs)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wynkoop 2021-04-01 05:44:42 UTC
I just installed a new freebsd 12.1 VM and on moving to /usr/ports/www/sws I discovered it did not exist.  This is with ports current as of 31 March 2021.

Being the author I just grabbed the code from my own web server with lynx and installed by hand.

Why was sws removed from ports?

What do I have to do to get it back in?

It has been perfectly functional since I contributed it and it runs on even the most recent versions.

There are times when you just need a super small web server that needs nothing more than /bin/sh to run.

Help.

Thanks.

-Brett
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2021-04-01 17:00:30 UTC
(In reply to Brett Wynkoop from comment #0)
> Why was sws removed from ports?

Apparently it failed to build:

portsjail% grep www/sws $PORTSDIR/MOVED
www/sws||2020-05-05|Has expired: Broken for more than 6 months
Comment 2 Brett Wynkoop 2021-04-01 20:51:05 UTC
Wish someone would have emailed me.  Not sure how it could fail to build.  The whole thing is a single man page, single /bin/sh script, and a config file.

Perhaps since the source site was off line for a bit that failed it.

Source system is back up now and has been for some time.

Can we get it back in?

Also I have a bug fix.  How do I go about updating to a new version that has the bug fixed?

Thanks so much!
Comment 3 Brett Wynkoop 2021-04-09 05:53:47 UTC
I just dropped the sws port dir into /usr/ports/www/sws on a freebsd 12.2 system and the results of make are below:

root@prd1:/usr/ports/www/sws # make
===>  License BSD2CLAUSE accepted by the user
===>   sws-1.0 depends on file: /usr/local/sbin/pkg - found
=> sws-1.0.tar.gz doesn't seem to exist in /var/ports/distfiles/.
=> Attempting to fetch http://prd4.wynn.com:8080/src/sws-1.0.tar.gz
fetch: http://prd4.wynn.com:8080/src/sws-1.0.tar.gz: size unknown
fetch: http://prd4.wynn.com:8080/src/sws-1.0.tar.gz: size of remote file is not known
sws-1.0.tar.gz                                        4886  B  118 kBps    00s
===> Fetching all distfiles required by sws-1.0 for building
===>  Extracting for sws-1.0
=> SHA256 Checksum OK for sws-1.0.tar.gz.
===>  Patching for sws-1.0
===>  Applying FreeBSD patches for sws-1.0 from /var/ports/www/sws/files
===>  Configuring for sws-1.0
===>  Building for sws-1.0
===>  Staging for sws-1.0
===>   Generating temporary packing list
mkdir -p /var/ports/www/sws/work/stage/usr/local/sws/docs /var/ports/www/sws/work/stage/usr/local/man/man8
touch /var/ports/www/sws/work/stage/usr/local/etc/sws.cfg
chmod 775 /var/ports/www/sws/work/stage/usr/local/sws/docs
chmod 644  /var/ports/www/sws/work/stage/usr/local/etc/sws.cfg
cp sws.txt /var/ports/www/sws/work/stage/usr/local/bin/sws
cp sws.8.txt  /var/ports/www/sws/work/stage/usr/local/man/man8/sws.8
chmod 755 /var/ports/www/sws/work/stage/usr/local/bin/sws
chmod 644 /var/ports/www/sws/work/stage/usr/local/man/man8/sws.8
====> Compressing man pages (compress-man)
root@prd1:/usr/ports/www/sws # 


Can we please get this put back into ports?
Comment 4 Brett Wynkoop 2021-04-09 06:06:13 UTC
root@prd1:/usr/ports/www/sws # make install
===>  Installing for sws-1.0
===>  Checking if sws is already installed
===>   Registering installation for sws-1.0
Installing sws-1.0...
root@prd1:/usr/ports/www/sws # make package
===>  Building package for sws-1.0
root@prd1:/usr/ports/www/sws # 

root@prd1:/usr/ports/www/sws # uname -a
FreeBSD prd1 12.2-RELEASE-p6 FreeBSD 12.2-RELEASE-p6 GENERIC  amd64
Comment 5 wynkoop 2021-08-09 06:33:50 UTC
Can I get someone to put this back in ports already please?

If you look through the ticket you will find that it builds!

I suspect there never was a build problem, just a short period of time where my source code server was down.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-09 07:21:32 UTC
(In reply to Brett Wynkoop from comment #2)

If you could include a patch that has bugfixes or improvements without a version (feature) update, that would be great, and for this issue would be a great time to do that. 

In the absence of other changes, a diff against the tree copying the port from the last known revision, readding the www/Makefile category entry, and removing the MOVED entry would also be suitable.
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-09 14:53:14 UTC
Hi,

I'm trying to revive it but only www/Makefile gets merged:

git log -- ww/sws:
---
commit d73586143810c2387c0a30025c1c7939a7e41f2b
Author: Dmitry Marakasov <amdmi3@FreeBSD.org>
Date:   Mon Sep 14 19:11:33 2015 +0000

    - Fix build from non-root; owner is not propagated to the package anyway, and doesn't seem to be needed here at all

    Approved by:    portmgr blanket

Notes:
    svn path=/head/; revision=396928

commit a5f08564afa5692c405cf9a70dae60b7d5b3a0c3
Author: Rui Paulo <rpaulo@FreeBSD.org>
Date:   Sun Mar 1 18:11:26 2015 +0000

    New port: www/sws

    sws was born out of a project requirement for a small universal Web
    server that could run on any POSIX platform to serve static
    content. Since it is written in /bin/sh it should run on any
    BSD/GNU-Linux/Unix system.

    PR:             197694
    Differential Revision:  https://reviews.freebsd.org/D1988
    Reviewed by:    swills
    Approved by:    swills (mentor)

Notes:
    svn path=/head/; revision=380221
---

git revert a5f08564afa5692c405cf9a70dae60b7d5b3a0c3 only merges www/Makefile not port himself.

Any clues?

Cheers
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-11-29 18:59:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a576a40bf19fd89d18dbbb180eb3629dc8bc6b9c

commit a576a40bf19fd89d18dbbb180eb3629dc8bc6b9c
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2023-11-29 18:55:20 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2023-11-29 18:58:13 +0000

    www/sws: Revive the port

    It was removed from the tree because sources were not fetchable.
    Author (and also maintainer) restored source files and asked port to be
    re-added to the tree
    PR:             254688
    Requested by:   Brett Wynkoop <wynkoop@wynn.com> (maintainer)

 MOVED                              |  1 -
 www/Makefile                       |  1 +
 www/sws/Makefile (new)             | 14 ++++++++++++++
 www/sws/distinfo (new)             |  3 +++
 www/sws/files/patch-Makefile (new) |  9 +++++++++
 www/sws/pkg-descr (new)            | 10 ++++++++++
 www/sws/pkg-plist (new)            |  4 ++++
 7 files changed, 41 insertions(+), 1 deletion(-)