Bug 254697 - devel/re2: Update to 20210401 and switch to CMake
Summary: devel/re2: Update to 20210401 and switch to CMake
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/google/re2/compare...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-01 17:10 UTC by Daniel Engberg
Modified: 2021-06-20 20:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for re2 (3.42 KB, patch)
2021-04-01 17:10 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-04-01 17:10:33 UTC 
Created attachment 223752 [details]
Patch for re2

Update to 20210401 and swtich to CMake
Reduce patch

Compile tested on FreeBSD 13.0-RC1 (aarch64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-04-01 17:16:45 UTC 
Reduces compilation time (Cmake build also excludes unit tests)
====> Compressing man pages (compress-man)
        34.37s real             2m38.72s user           6.01s sys

====> Compressing man pages (compress-man)
        1m2.28s real            5m27.19s user           10.08s sys

CMake files are also required by some upstream projects which may be of interest.
https://bugs.archlinux.org/task/67739
https://github.com/macports/macports-ports/pull/9836
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-04-01 23:44:43 UTC 
I forgot to mention, the hardware used for testing is a RockPro64 SBC.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-06-20 20:39:51 UTC 
(In reply to Daniel Engberg from comment #1)

grpc builds fine with current re2.

(In reply to Daniel Engberg from comment #0)

re2 is fine now. I do not want to maintain unnececessary extra local patch.