Bug 254702 - www/netsurf: fix preferences dialog bug, clean up build warnings
Summary: www/netsurf: fix preferences dialog bug, clean up build warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-01 21:23 UTC by waitman
Modified: 2021-04-06 16:27 UTC (History)
0 users

See Also:
nc: maintainer-feedback+


Attachments
update netsurf port to 3.10_1 (11.67 KB, patch)
2021-04-01 21:23 UTC, waitman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description waitman 2021-04-01 21:23:40 UTC
Created attachment 223757 [details]
update netsurf port to 3.10_1

GTK will not use a custom supplied gettext function with Builder xml ui on FreeBSD, which causes the the preferences dialog to have translation keys instead of English, etc, readable text. Netsurf uses a translation scheme with key/value pairs in a gzipped file instead of using gettext po files, so when the ui is loaded by GTK the calls to translate using gettext() fail because it cannot find the po translation files.

This fix generates a language specific ui for this dialog during buildtime so on-the-fly translation is not required on the preferences dialog. The program selects the ui file which corresponds to their locale setting in env.
Comment 1 Neel Chauhan freebsd_committer 2021-04-01 21:42:19 UTC
LGTM. Will commit once the ports tree has converted to git (which we are in the process in).
Comment 2 Neel Chauhan freebsd_committer 2021-04-06 16:25:31 UTC
Committed!
Comment 3 commit-hook freebsd_committer 2021-04-06 16:27:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c7d712568cc4dbe35df64f48f576498361160333

commit c7d712568cc4dbe35df64f48f576498361160333
Author:     Neel Chauhan <nc@FreeBSD.org>
AuthorDate: 2021-04-06 16:23:54 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-04-06 16:26:55 +0000

    www/netsurf: Fix preferences dialog bug and fix build warnings

    PR:             254702
    Submitted by:   waitman AT waitman DOT net

 www/netsurf/Makefile                               | 39 +++++-----
 www/netsurf/files/Makefile.config                  |  2 +-
 www/netsurf/files/buildui.pl (new)                 | 82 ++++++++++++++++++++++
 www/netsurf/files/patch-Makefile                   | 50 ++++++++++++-
 .../files/patch-frontends_gtk_Makefile.defaults    |  8 ++-
 .../files/patch-frontends_gtk_preferences.c (new)  | 33 +++++++++
 .../files/patch-frontends_gtk_resources.c (new)    | 22 ++++++
 www/netsurf/pkg-plist                              |  5 ++
 8 files changed, 218 insertions(+), 23 deletions(-)