Bug 254734 - x11/keybinder-gtk3: add DOCS/EXAMPLES options
Summary: x11/keybinder-gtk3: add DOCS/EXAMPLES options
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-03 03:39 UTC by John Hein
Modified: 2021-04-17 07:49 UTC (History)
1 user (show)

See Also:


Attachments
[patch] add DOCS/EXAMPLES (3.59 KB, patch)
2021-04-03 03:39 UTC, John Hein
no flags Details | Diff
[patch] add DOCS/EXAMPLES v2 (4.25 KB, patch)
2021-04-17 05:30 UTC, Rainer Hurling
no flags Details | Diff
[patch] add DOCS/EXAMPLES v3 (4.56 KB, patch)
2021-04-17 07:49 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2021-04-03 03:39:01 UTC
Created attachment 223781 [details]
[patch] add DOCS/EXAMPLES

Add DOCS & EXAMPLES options for x11/keybinder-gtk3.  The examples were never installed before and can be useful.  They are lightweight.

While here accommodate portlint warnings (line ordering).  Also get rid of unnecessary DISTNAME complication.  Bump PORTREVISION (EXAMPLES is on by default - that will change the package).

QA:
  portlint (ok)
  poudriere (ok, tested with all options combinations)
Comment 1 Rainer Hurling freebsd_committer 2021-04-17 05:30:32 UTC
Created attachment 224175 [details]
[patch] add DOCS/EXAMPLES v2

Hi John,

I tried your patch on Poudriere and it builds and installs fine, as you mentioned before ;)

However, if I also build the dependent ports [1], there is a conflict in x11/guake:

pkg-static: keybinder-0.3.1_5 conflicts with keybinder-gtk3-0.3.2_1 
(installs files into the same place).  
Problematic file: /usr/local/share/examples/keybinder/Makefile

Obviously, guake needs both keybinder versions, gtk2 and gtk3, as run dependencies. I solved this conflict by also adding the version number to the keybinder directory under examples.


[1] audio/pragha, audio/xfce4-pulseaudio-plugin, deskutils/synapse, deskutils/xfce4-volumed-pulse, multimedia/peek, x11/guake, x11/terminator, x11/ulauncher

BTW: I reordered some Makefile vars again after recommendations from portclippy.


If you are fine with these changes, I would commit the patch v2 :)
Comment 2 Rainer Hurling freebsd_committer 2021-04-17 07:49:16 UTC
Created attachment 224179 [details]
[patch] add DOCS/EXAMPLES v3

I just noticed that the docs are installed even if the DOCS option is disabled.

From the gtk2 version of the keybinder port I have borrowed the corresponding functionality, with which now actually no more docs are installed :)