Bug 254743 - New port: emulators/executor2000: Modern fork of the classic Mac emulator
Summary: New port: emulators/executor2000: Modern fork of the classic Mac emulator
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-03 18:24 UTC by probono
Modified: 2021-05-05 20:09 UTC (History)
2 users (show)

See Also:


Attachments
executor2000.shar (7.23 KB, text/plain)
2021-04-03 18:24 UTC, probono
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description probono 2021-04-03 18:24:34 UTC
Created attachment 223786 [details]
executor2000.shar

This is a modernized (as of 2019) fork of Executor, the "original" version of
which you can still find upstream at https://github.com/ctm/executor.

Why "2000"? Because that's what we used to call the future.

Executor was a commercially available Mac emulator in the 90s - what makes it
different from other Mac emulators is that it doesn't need a ROM file or any
original Apple software to run; rather, it attempts to re-implement the classic
Mac OS APIs, just as WINE does for Windows.

WWW: https://github.com/autc04/executor
Comment 1 Daniel Engberg 2021-04-03 21:44:00 UTC
DISTVERSION is not sane, please read the Porters Handbook about using Github.

Missing LICENSE_FILE entry (see Porters Handbook)

USES= should be on one line

Missing CXX17 compiler entry
Ref: https://github.com/autc04/executor/blob/8473c02f1579085461a1b36d8b1ce6ed11174023/CMakeLists.txt#L24
https://svnweb.freebsd.org/ports/head/Mk/Uses/compiler.mk?revision=562226&view=markup

Perl and readline(only build?) build dependencies should use USES= instead
https://svnweb.freebsd.org/ports/head/Mk/Uses/perl5.mk?revision=542642&view=markup
https://svnweb.freebsd.org/ports/head/Mk/Uses/readline.mk?revision=498476&view=markup

QT dependencies should only be defined using USE_QT variable
https://svnweb.freebsd.org/ports/head/Mk/Uses/qt.mk?revision=564908&view=markup

Can we reuse at least lmdb, googletest from ports?
https://docs.freebsd.org/en/books/porters-handbook/book.html#bundled-libs

Are patches upstreamed?

Are do-install and post-install needed?

Does it pass poudriere?

If possible please submit patches as .patch or .diff files instead, it's much easier to review.

Best regards,
Daniel
Comment 2 Daniel Engberg 2021-05-05 20:09:38 UTC
Friendly ping