Bug 254796 - New port: emulators/minivmac: Miniature Macintosh emulator
Summary: New port: emulators/minivmac: Miniature Macintosh emulator
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-05 15:55 UTC by probono
Modified: 2021-04-05 21:48 UTC (History)
2 users (show)

See Also:


Attachments
minivmac.shar (3.20 KB, text/plain)
2021-04-05 15:55 UTC, probono
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description probono 2021-04-05 15:55:45 UTC
Created attachment 223834 [details]
minivmac.shar

Revives the port that used to be at
https://svnweb.freebsd.org/ports/head/emulators/minivmac/?pathrev=418056
Comment 1 Daniel Engberg 2021-04-05 18:13:38 UTC
Hi,

A few things that needs to be adressed:

PORTVERSION --> DISTVERSION
See "Table 5.2. Package Naming Examples" in Porters Handbook

36.04 seems to be the current version (3.0.0 is very out of date)
https://www.gryphel.com/c/minivmac/download.html

http://mirror.its.dal.ca/freebsd/distfiles/ is not a proper MASTER_SITES
https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-master_sites

MAINTAINER needs to be a person, importing unmaintained ports is in general a no go.

LICENSE_FILE definition is missing
https://docs.freebsd.org/en/books/porters-handbook/book.html#licenses-license_file-ex1

CFLAGS can most likely be replaced by USES= localbase
https://svnweb.freebsd.org/ports/head/Mk/Uses/localbase.mk?revision=423014&view=markup

pkg-message appears to be about of date? Website last updated in 2002

pkg-descr is out of date, site redirects to https://www.gryphel.com/c/minivmac/

Best regards,
Daniel
Comment 2 Daniel Engberg 2021-04-05 18:23:28 UTC
pkg-message appears to be about of date should be pkg-message appears to be out of date

I apologise about the typo
Comment 3 probono 2021-04-05 19:20:39 UTC
Thanks for reviewing this. I know there are newer versions but my intention was just to restore the port that had been in Ports previously.
Comment 4 Chris Rees freebsd_committer 2021-04-05 19:41:04 UTC
Hm, might be worth getting the most recent version in since we're working on it here.
Comment 5 Daniel Engberg 2021-04-05 21:48:46 UTC
We do however in general want to keep supported and up to date versions by upstream and in repo. As long as its not up to date it shouldn't be imported back as that were the reason for it being removed in the first place (not compiling most likely a result of being not up to date and/or unmaintained)