Created attachment 223838 [details] Update to 1.7.0 Instead of SDL1 and 2, SDL2 is the only supported Version since Exult 1.7.
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field Q/A: FATAL: Makefile: [19]: use a tab (not space) after a variable name FATAL: Makefile: [20]: use a tab (not space) after a variable name FATAL: Makefile: [35]: use a tab (not space) after a variable name FATAL: Makefile: [41]: use a tab (not space) after a variable name FATAL: Makefile: [47]: use a tab (not space) after a variable name Would you mind fixing these? Note: $FreeBSD$ headers have been removed.
Created attachment 223915 [details] Revised patch Removed spaces and added missing LIB_DEPENDS libpng.so libogg.so libfreetype.so and USE_GNOME gtk30 cairo gdkpixbuf2
Created attachment 223916 [details] Revised patch Removed $FreeBSD$ headers
Upstream just bumped it to 20210410 I also think that we should be able to convert this to DISTVERSION (haven't tried it though) DISTVERSIONPREFIX= v DISTVERSION= 1.7.0.20210410 ... GH_TAGNAME= snapshot-${DISTVERSIONPREFIX}${DISTVERSION} USES= compiler:c++11-lib and USE_CXXSTD= c++17 conflicts with eachother :-) Set --with-optimization=none to avoid overriding Ports framework Please considerring a debug knob/toggle glib dep seems to be missing? Best regards, Daniel
Created attachment 223987 [details] Revised patch Changed to DISTVERSION, removed conflict c++11/c++17, added glib dependency, added DEBUG knob. Can you please have a look if i used "--with-optimization=none" correctly? Thanks for the Hints and have a great Day, Gian
Created attachment 223988 [details] Revised patch
Created attachment 223989 [details] Revised patch -> Alsa supported
Created attachment 224006 [details] Patch for exult Style fixes, pet portlint Use alphabetical order if possible and rearrange for readability Make ALSA optional Poudriere testport OK 12.2-RELEASE (amd64) - Only tested with default options
Hi Gian-Simon, Great work! I made some style fixes and made ALSA optional as I assume that SDL is also used for sound(?). Sorry for late reply, my buildbox is really slow.
Hi Daniel, Thanks for the added Alsa-option. No hurry (you probably have weekend too) better having a nice port than to rush stuff out. I read at github the code is at c++14 ATM but if the compiler can do c++17, it automatically changes to 17 (which is their future target). So maybe change default to c++17? What do you think? https://github.com/exult/exult/pull/50#issuecomment-704588291
We already set it at c++17 (discussed in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254801#c4 ) so I think we can leave it at that. I think it mainly affects 11.4 which soon is EOL anyway. If you can give the options (FLUIDSYNTH, GIMP, THUMBNAILER) a compile test and verify that they don't break plist (make check-plist) or using Poudriere I think it should be good to go as far as I can tell.
>If you can give the options (FLUIDSYNTH, GIMP, THUMBNAILER) a compile test and verify that they don't break plist (make check-plist) or using Poudriere I think it should be good to go as far as I can tell. All of them don't break plist, however the Gimp-plugin does not compile ATM.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d24b0121abfa01d0ba3f0da54b44745b93c08da9 commit d24b0121abfa01d0ba3f0da54b44745b93c08da9 Author: Fernando ApesteguÃa <fernape@FreeBSD.org> AuthorDate: 2021-04-08 11:00:14 +0000 Commit: Fernando ApesteguÃa <fernape@FreeBSD.org> CommitDate: 2021-04-13 05:59:23 +0000 games/exult: Update to 1.7.0 ChangeLog: https://github.com/exult/exult/releases/tag/snapshot-v1.7.0.20210405 PR: 254801 Reported by: gspurki@gmail.com games/exult/Makefile | 44 +++++++++----------- games/exult/distinfo | 5 ++- games/exult/files/patch-configure.ac (gone) | 20 --------- games/exult/files/pkg-message.in | 1 - games/exult/pkg-descr | 2 +- games/exult/pkg-plist | 63 ++++++++++++++++++++--------- 6 files changed, 65 insertions(+), 70 deletions(-)
Committed, Thanks!
Hy Fernando, What is that for a patch? several thing are not good. Alsa is supported, no Debug option, no Alsa option, no additional libdepends. It's like the first "proto"-patch went in.
(In reply to Gian-Simon Purkert from comment #15) Hi, Sorry. I might have had not the last one. Would you mind leaving just one patch as de definite and marking all the rest as obsolete? Thanks
Hi Fernando, Thank you very much for the fast answer, there is now just one Attachment "Patch for exult (8.06 KB, patch)" Have a great Day, Gian-Simon
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=91f15977cec6282962f2fd6599799b16949e8c21 commit 91f15977cec6282962f2fd6599799b16949e8c21 Author: Fernando ApesteguÃa <fernape@FreeBSD.org> AuthorDate: 2021-04-13 11:15:11 +0000 Commit: Fernando ApesteguÃa <fernape@FreeBSD.org> CommitDate: 2021-04-13 11:19:35 +0000 games/exult: fixup after aae00cbee1cef8d51abff5de932f7cf64c62dc87 Apparently, I did not pick up the very last patch in the PR. This additional commit adds the remaining bits discussed in the PR: * Convert to DISTVERSION * Use c++17 * Add missing glib dependency * Make ALSA optional * Reorder some variables PR: 254801 Reported by: gspurki@gmail.com games/exult/Makefile | 61 +++++++++++++++++++++++++++++++-------------------- games/exult/distinfo | 6 ++--- games/exult/pkg-descr | 13 +++++++---- games/exult/pkg-plist | 32 +++++++++++++++------------ 4 files changed, 67 insertions(+), 45 deletions(-)
We should be good now. Thanks for the heads up!