Bug 254850 - dns/nsd: Update to 4.3.6
Summary: dns/nsd: Update to 4.3.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://nlnetlabs.nl/news/2021/Apr/06...
Depends on:
Reported: 2021-04-07 11:03 UTC by Jaap Akkerhuis
Modified: 2021-04-08 20:51 UTC (History)
2 users (show)

See Also:

Patch to upgrade (798 bytes, patch)
2021-04-07 11:03 UTC, Jaap Akkerhuis
jaap: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaap Akkerhuis 2021-04-07 11:03:03 UTC
Created attachment 223893 [details]
Patch to upgrade

NSD 4.3.6 is available:
sha256 bee6c0cf5525acc41dade9ec9e29435299211b0de290059878f7e53249e75f18
pgp https://nlnetlabs.nl/downloads/nsd/nsd-4.3.6.tar.gz.asc

This release contains a bug fix for a zone file parse failure for text
records. The release also adds the feature to print a local address, if
the address is configured, in dnstap logs. The interface for nsd-control
can be specified with an interface name. The zone that was parse
successfully can be printed with the nsd-checkzone -p option. Also added
is support to emit DNS extended errors via the EDNS option from RFC8914.
It is possible to stop queries for certain zones, depending on IP
address and TSIG key, with the new allow-query option, for zones that do
not need to be queried, like meta zones with configuration information.

A difference with rc1 is that the configure script is built with
autoreconf, so that --enable-systemd works.

- Fix #146 with #147: DNSTAP log the local address of the server
  with the dnstap logs.
- Enable configuring a control-interface by interface name.
- A -p option to nsd-checkzone to print a successfully read zone.
- Add Extended DNS Errors RFC8914
- Per zone Access Control List for queries
  with an allow-query: option.

- Prevent a few more yacc clashes.
- Merge PR #153 from fobser: Repair -fno-common linker errors
- Fix uninitialized access of log_buf in error printout on apply ixfr.
- Fix AF_LOCAL compile error for Solaris.
- Fix ifaddrs compile error for Solaris.
- Fix ifaddrs.h compile error for Solaris.
- Man page documentation for dnstap options.
- Fix segfault on high verbosity for TLS channels with dnstap log
  local address.
- Fix #163: A TSIG noncompliance with RFC 2845.
- Fix that wildcard is printed as a star instead of escaped, in
  logs and in written zone files.
- Fix double config.h include in configlexer.c
- Fix to remove configyyrename from makedist.sh and also
  update the flex and bison rules there to add the "c_" prefix.
- Fix configure to use header checks with compile.
- Fix warning about unused function log_addr.
- Fix #154: TXT with parentheses fails in 4.3.5.
- Align parsing of TXT elements with how bind does it.
- Fix configure failure for enable systemd because of autoconf.
Comment 1 daniel.engberg.lists 2021-04-07 11:48:02 UTC

I few things I spotted

See "Table 5.2. Package Naming Examples" in Porters Handbook

http://www.nlnetlabs.nl - redirects to https
ftp.rhnet.is doesn't seem to resolve


CONFLICTS= can probably be removed by now?

Best regards,
Comment 2 commit-hook freebsd_committer 2021-04-08 03:32:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b69bbb6794847ce677f8466ff2911a52958f1463

commit b69bbb6794847ce677f8466ff2911a52958f1463
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2021-04-08 03:29:37 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-04-08 03:29:37 +0000

    dns/nsd: Update to 4.3.6

    Changelog https://nlnetlabs.nl/news/2021/Apr/06/nsd-4.3.6-released/

    PR:             254850
    Reviewed by:    daniel.engberg.lists@pyret.net
    Approved by:    Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)

 dns/nsd/Makefile | 9 +++------
 dns/nsd/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 9 deletions(-)
Comment 3 Kevin Bowling freebsd_committer 2021-04-08 03:34:27 UTC
Thanks to both of you for the patch and review.
Comment 4 Jaap Akkerhuis 2021-04-08 12:57:29 UTC
(In reply to daniel.engberg.lists from comment #1)

Note it has always been using PORTVERSION as far as I know. This seems to be standard for (dns) ports. A quick scan shows 248 times PORTVERSION against 69 times for DISTVERSION.

It if ftp.rhnet.is stopped working, it is fine with me.

The LIB_DEPENDS += was on request since 2014 (See bug #186693).

I would prefer to keep the CONFLICTS line. There is no direct need to remove it, and I don't want to speculate how many people are still running old cruft.
Comment 5 daniel.engberg.lists 2021-04-08 20:03:15 UTC
(In reply to Jaap Akkerhuis from comment #4)

We've never separated ports by category and for that matter ports framework do move forward like most software. :)
This specific change is more than 2 years old and while there 
hasn't been a treewide sweep we should try to follow Porter's handbook as much as possible.

First occurrence of LIB_DEPENDS shouldn't use += however following once should otherwise you'd be overriding the previous variable.

As for conflicts, nsd3 was removed 5 years ago and nsd got bumped to 4.x in late 2013 so I think that's a reasonable change.
Comment 6 Kevin Bowling freebsd_committer 2021-04-08 20:51:04 UTC
The suggested changes matched the standards and directions of the ports tree.  It's stylistic and should not impact future updates to the port.