Created attachment 223893 [details]
Patch to upgrade
NSD 4.3.6 is available:
This release contains a bug fix for a zone file parse failure for text
records. The release also adds the feature to print a local address, if
the address is configured, in dnstap logs. The interface for nsd-control
can be specified with an interface name. The zone that was parse
successfully can be printed with the nsd-checkzone -p option. Also added
is support to emit DNS extended errors via the EDNS option from RFC8914.
It is possible to stop queries for certain zones, depending on IP
address and TSIG key, with the new allow-query option, for zones that do
not need to be queried, like meta zones with configuration information.
A difference with rc1 is that the configure script is built with
autoreconf, so that --enable-systemd works.
- Fix #146 with #147: DNSTAP log the local address of the server
with the dnstap logs.
- Enable configuring a control-interface by interface name.
- A -p option to nsd-checkzone to print a successfully read zone.
- Add Extended DNS Errors RFC8914
- Per zone Access Control List for queries
with an allow-query: option.
- Prevent a few more yacc clashes.
- Merge PR #153 from fobser: Repair -fno-common linker errors
- Fix uninitialized access of log_buf in error printout on apply ixfr.
- Fix AF_LOCAL compile error for Solaris.
- Fix ifaddrs compile error for Solaris.
- Fix ifaddrs.h compile error for Solaris.
- Man page documentation for dnstap options.
- Fix segfault on high verbosity for TLS channels with dnstap log
- Fix #163: A TSIG noncompliance with RFC 2845.
- Fix that wildcard is printed as a star instead of escaped, in
logs and in written zone files.
- Fix double config.h include in configlexer.c
- Fix to remove configyyrename from makedist.sh and also
update the flex and bison rules there to add the "c_" prefix.
- Fix configure to use header checks with compile.
- Fix warning about unused function log_addr.
- Fix #154: TXT with parentheses fails in 4.3.5.
- Align parsing of TXT elements with how bind does it.
- Fix configure failure for enable systemd because of autoconf.
I few things I spotted
PORTVERSION --> DISTVERSION
See "Table 5.2. Package Naming Examples" in Porters Handbook
http://www.nlnetlabs.nl - redirects to https
ftp.rhnet.is doesn't seem to resolve
LIB_DEPENDS+= should be LIB_DEPENDS=
CONFLICTS= can probably be removed by now?
A commit in branch main references this bug:
Author: Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2021-04-08 03:29:37 +0000
Commit: Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-04-08 03:29:37 +0000
dns/nsd: Update to 4.3.6
Reviewed by: email@example.com
Approved by: Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)
dns/nsd/Makefile | 9 +++------
dns/nsd/distinfo | 6 +++---
2 files changed, 6 insertions(+), 9 deletions(-)
Thanks to both of you for the patch and review.
(In reply to daniel.engberg.lists from comment #1)
Note it has always been using PORTVERSION as far as I know. This seems to be standard for (dns) ports. A quick scan shows 248 times PORTVERSION against 69 times for DISTVERSION.
It if ftp.rhnet.is stopped working, it is fine with me.
The LIB_DEPENDS += was on request since 2014 (See bug #186693).
I would prefer to keep the CONFLICTS line. There is no direct need to remove it, and I don't want to speculate how many people are still running old cruft.
(In reply to Jaap Akkerhuis from comment #4)
We've never separated ports by category and for that matter ports framework do move forward like most software. :)
This specific change is more than 2 years old and while there
hasn't been a treewide sweep we should try to follow Porter's handbook as much as possible.
First occurrence of LIB_DEPENDS shouldn't use += however following once should otherwise you'd be overriding the previous variable.
As for conflicts, nsd3 was removed 5 years ago and nsd got bumped to 4.x in late 2013 so I think that's a reasonable change.
The suggested changes matched the standards and directions of the ports tree. It's stylistic and should not impact future updates to the port.