Bug 254878 - www/tomcat10: rc.d script has an invalid shebang
Summary: www/tomcat10: rc.d script has an invalid shebang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Juraj Lutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-08 10:47 UTC by Lapo Luchini
Modified: 2021-05-06 13:30 UTC (History)
4 users (show)

See Also:
vvd: maintainer-feedback+


Attachments
fix shebang (292 bytes, patch)
2021-05-06 12:45 UTC, Lapo Luchini
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2021-04-08 10:47:19 UTC
The initial '#' is missing.

It works as expected, but still gives an error:

% sudo service tomcat10 start
/usr/local/etc/rc.d/tomcat_ws: !/bin/sh: not found
Starting tomcat_ws.
Comment 1 VVD 2021-04-08 11:10:07 UTC
Weird. I see it. Other tomcat ports are not affected.
Can you create patch?
Comment 2 Lapo Luchini 2021-05-06 12:45:49 UTC
Created attachment 224726 [details]
fix shebang

Here's the patch.
Comment 3 VVD 2021-05-06 12:59:42 UTC
Comment on attachment 224726 [details]
fix shebang

Thanks!
I'll ask to commit it.
Comment 4 commit-hook freebsd_committer 2021-05-06 13:23:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5de7b0cf8ad4b38de466c929446e6fbf98858cc

commit a5de7b0cf8ad4b38de466c929446e6fbf98858cc
Author:     Lapo Luchini <lapo@lapo.it>
AuthorDate: 2021-05-06 13:19:58 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2021-05-06 13:22:35 +0000

    www/tomcat10: Fix shebang in rc.d script

    PR:             254878
    Reported by:    Lapo Luchini <lapo@lapo.it>
    Approved by:    vvd@unislabs.com (maintainer)

 www/tomcat10/files/tomcat10.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer 2021-05-06 13:28:19 UTC
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=afa1357f1caab752b93b4c5fd0742d385e84229a

commit afa1357f1caab752b93b4c5fd0742d385e84229a
Author:     Lapo Luchini <lapo@lapo.it>
AuthorDate: 2021-05-06 13:19:58 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2021-05-06 13:26:31 +0000

    www/tomcat10: Fix shebang in rc.d script

    PR:             254878
    Reported by:    Lapo Luchini <lapo@lapo.it>
    Approved by:    vvd@unislabs.com (maintainer)

    (cherry picked from commit a5de7b0cf8ad4b38de466c929446e6fbf98858cc)

 www/tomcat10/files/tomcat10.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Juraj Lutter freebsd_committer 2021-05-06 13:30:44 UTC
Committed, thanks.