Bug 254880 - ifnet(9) mentions splnet
Summary: ifnet(9) mentions splnet
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-08 11:11 UTC by Dmitry Chagin
Modified: 2021-04-16 08:42 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Chagin freebsd_committer freebsd_triage 2021-04-08 11:11:05 UTC 
ifnet(9) mentions the deprecated splx API. the phrase below should be rewritten or removed:
'if_down(), ifioctl(), ifpromisc(), and if_up() must be called at splnet() or higher.'
Comment 1 Ed Maste freebsd_committer freebsd_triage 2021-04-08 14:30:54 UTC 
This phrase indeed makes no sense now. I think it can just be deleted.
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2021-04-08 14:35:58 UTC 
(In reply to Ed Maste from comment #1)
I agree, best to just delete that sentence.

It does highlight some of the ifnet locking problems we have today.  For instance, ifpromisc() modifies if_flags without any synchronization.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-04-09 14:24:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=f2400e6e832d42ca72b0d04ecd070598f4a81eb7

commit f2400e6e832d42ca72b0d04ecd070598f4a81eb7
Author:     Dmitry Chagin <dchagin@FreeBSD.org>
AuthorDate: 2021-04-09 14:22:12 +0000
Commit:     Dmitry Chagin <dchagin@FreeBSD.org>
CommitDate: 2021-04-09 14:22:12 +0000

    Removed the reference to the deprecated splx API from ifnet(9).

    Reviewed by:            emaste, markj
    PR:                     254880
    MFC After:              1 week
    Differential Revision:  https://reviews.freebsd.org/D29666

 share/man/man9/ifnet.9 | 9 ---------
 1 file changed, 9 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-04-16 08:32:27 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=796d1209fb4a5b599561e094f7ce01e0b0596ad4

commit 796d1209fb4a5b599561e094f7ce01e0b0596ad4
Author:     Dmitry Chagin <dchagin@FreeBSD.org>
AuthorDate: 2021-04-09 14:22:12 +0000
Commit:     Dmitry Chagin <dchagin@FreeBSD.org>
CommitDate: 2021-04-16 08:31:22 +0000

    Removed the reference to the deprecated splx API from ifnet(9).

    Reviewed by:            emaste, markj
    PR:                     254880
    Differential Revision:  https://reviews.freebsd.org/D29666

    (cherry picked from commit f2400e6e832d42ca72b0d04ecd070598f4a81eb7)

 share/man/man9/ifnet.9 | 9 ---------
 1 file changed, 9 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-04-16 08:36:28 UTC 
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c91586dcfc9ed2cb94b672b6ac0a21aaace2dff1

commit c91586dcfc9ed2cb94b672b6ac0a21aaace2dff1
Author:     Dmitry Chagin <dchagin@FreeBSD.org>
AuthorDate: 2021-04-09 14:22:12 +0000
Commit:     Dmitry Chagin <dchagin@FreeBSD.org>
CommitDate: 2021-04-16 08:35:14 +0000

    Removed the reference to the deprecated splx API from ifnet(9).

    Reviewed by:            emaste, markj
    PR:                     254880
    Differential Revision:  https://reviews.freebsd.org/D29666

    (cherry picked from commit f2400e6e832d42ca72b0d04ecd070598f4a81eb7)

 share/man/man9/ifnet.9 | 9 ---------
 1 file changed, 9 deletions(-)