Bug 254897 - Document kern.geom.notaste sysctl
Summary: Document kern.geom.notaste sysctl
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-doc (Nobody)
URL:
Keywords: easy, needs-patch
Depends on:
Blocks: 44034
  Show dependency treegraph
 
Reported: 2021-04-09 00:14 UTC by Jeremy Chadwick
Modified: 2023-10-06 16:07 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (des)


Attachments
Patch to geom.4 (547 bytes, patch)
2021-09-03 22:42 UTC, Felix Johnson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick 2021-04-09 00:14:18 UTC
No where in man pages, or in the Handbook, is the kern.geom.notaste sysctl documented.

I learned of this sysctl only today via this mailing list post: https://lists.freebsd.org/pipermail/freebsd-stable/2021-April/093504.html

The code is in src/sys/geom/geom_kern.c, and was introduced 7 years ago in r255860 -- https://svnweb.freebsd.org/base/head/sys/geom/geom_kern.c?revision=255860&view=markup

Please document it somewhere (bare minimum, within geom(4)).
Comment 1 Felix Johnson freebsd_triage 2021-09-03 22:42:34 UTC
Created attachment 227655 [details]
Patch to geom.4

Add a mention of the kern.geom.notaste sysctl to the TASTING section of geom.4.
Comment 2 Benedict Reuschling freebsd_committer freebsd_triage 2023-10-06 15:21:55 UTC
I've created a review for the (slightly modified) patch here:
https://reviews.freebsd.org/D42109
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-06 16:05:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a5bebe4359ef3f80f592dcc989b4088f18abb939

commit a5bebe4359ef3f80f592dcc989b4088f18abb939
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2023-10-06 15:58:32 +0000
Commit:     Benedict Reuschling <bcr@FreeBSD.org>
CommitDate: 2023-10-06 16:02:49 +0000

    geom.4: Document kern.geom.notaste sysctl

    Reported by:    jdc_koitsu.org
    PR:             254897
    Approved by:    des
    Event:          Oslo Hackathon
    Differential Revision:  https://reviews.freebsd.org/D42109

 share/man/man4/geom.4 | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Comment 4 Benedict Reuschling freebsd_committer freebsd_triage 2023-10-06 16:07:59 UTC
A fix was committed, thanks to des' review. PR closed.