Bug 255023 - lang/spidermonkey78 js::SharedArrayRawBufferRefs not public API but used by it
Summary: lang/spidermonkey78 js::SharedArrayRawBufferRefs not public API but used by it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-13 05:03 UTC by Stephen Hurd
Modified: 2021-08-29 00:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)


Attachments
Patch from Gentoo with leading /s removed. (391 bytes, text/plain)
2021-04-13 05:03 UTC, Stephen Hurd
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Hurd freebsd_committer 2021-04-13 05:03:31 UTC
Created attachment 224072 [details]
Patch from Gentoo with leading /s removed.

As outlined in the Mozilla bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1644600:

And solved in this Gentoo bug
https://bugs.gentoo.org/759985

Without it being marked public, the StructuredClone stuff can't be used.  I've attached the slightly modified patch from the Gentoo report, which I have tested by dropping into the lang/spidermonkey78/files directory.
Comment 1 commit-hook freebsd_committer 2021-08-29 00:14:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6cd9df2791564cbeaf88824acd5570ef184f8b72

commit 6cd9df2791564cbeaf88824acd5570ef184f8b72
Author:     Steve Wills <swills@FreeBSD.org>
AuthorDate: 2021-08-29 00:12:38 +0000
Commit:     Steve Wills <swills@FreeBSD.org>
CommitDate: 2021-08-29 00:13:34 +0000

    lang/spidermonkey78: bug fixes

    * fix js78-config --libs
    * fix js::SharedArrayRawBufferRefs public API

    PR:             255023
    PR:             255024
    Reported by:    shurd

 lang/spidermonkey78/Makefile                           |  2 +-
 .../files/patch-js_public_StructuredClone.h (new)      | 13 +++++++++++++
 .../files/patch-js_src_build_js-config.in (new)        | 18 ++++++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)
Comment 2 Steve Wills freebsd_committer 2021-08-29 00:15:06 UTC
Fix committed, thanks for the report!