Bug 255024 - lang/spidermonkey78 configure script --libs broken
Summary: lang/spidermonkey78 configure script --libs broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-13 05:05 UTC by Stephen Hurd
Modified: 2021-08-29 00:14 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Hurd freebsd_committer freebsd_triage 2021-04-13 05:05:13 UTC 
`js78-config --libs` output is incorrect.

I modified my local copy by just copying the MOZ_JS_LIBS contents into the second-last line (the only line that uses it).
Comment 1 Stephen Hurd freebsd_committer freebsd_triage 2021-04-13 17:08:25 UTC 
Also, the -std= bit does not actually work with the headers... -std=c++17 is now required, so if you're patching the config script, that should be fixed as well.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-29 00:14:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6cd9df2791564cbeaf88824acd5570ef184f8b72

commit 6cd9df2791564cbeaf88824acd5570ef184f8b72
Author:     Steve Wills <swills@FreeBSD.org>
AuthorDate: 2021-08-29 00:12:38 +0000
Commit:     Steve Wills <swills@FreeBSD.org>
CommitDate: 2021-08-29 00:13:34 +0000

    lang/spidermonkey78: bug fixes

    * fix js78-config --libs
    * fix js::SharedArrayRawBufferRefs public API

    PR:             255023
    PR:             255024
    Reported by:    shurd

 lang/spidermonkey78/Makefile                           |  2 +-
 .../files/patch-js_public_StructuredClone.h (new)      | 13 +++++++++++++
 .../files/patch-js_src_build_js-config.in (new)        | 18 ++++++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)
Comment 3 Steve Wills freebsd_committer freebsd_triage 2021-08-29 00:14:56 UTC 
Fix committed, thanks for the report!