Bug 255217 - games/scummvm: Build all Engines added some LibD's
Summary: games/scummvm: Build all Engines added some LibD's
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-19 11:05 UTC by Gian-Simon Purkert
Modified: 2021-07-05 11:15 UTC (History)
0 users

See Also:
kai: maintainer-feedback+


Attachments
Enable all Engines (813 bytes, patch)
2021-04-19 11:06 UTC, Gian-Simon Purkert
no flags Details | Diff
scummvm-add-TTS-and-XENGINES-options.patch (1.92 KB, patch)
2021-07-05 11:15 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2021-04-19 11:05:55 UTC
Added missing 

libspeechd.so:accessibility/speech-dispatcher
and
USE_GNOME=	gtk30 cairo

Configure Arg:
--enable-all-engines
Comment 1 Gian-Simon Purkert 2021-04-19 11:06:22 UTC
Created attachment 224247 [details]
Enable all Engines
Comment 2 Kai Knoblich freebsd_committer 2021-04-22 17:33:50 UTC
(In reply to Gian-Simon Purkert from comment #0)

Thank you for the patch, I'll take a closer look at it the next few days. 

I have already checked my recent build logs regarding the missing dependencies, but couldn't find anything so I assume that you use a non-poudriere build environment?
Comment 3 Gian-Simon Purkert 2021-04-22 20:17:08 UTC
Thanks, 

Since residualvm is getting merged with scummvm is think it's a good idea to build all engines. If you start a game that uses a "non-stable" engine you get a warning anyway.

Yes build the make-way.
Comment 4 Gian-Simon Purkert 2021-06-07 10:55:47 UTC
Hy Kai,

Could you took some time to review the patch.

Greetings,

GS
Comment 5 Kai Knoblich freebsd_committer 2021-06-10 05:15:44 UTC
(In reply to Gian-Simon Purkert from comment #4)

Unfortunately, "next days" has become "next weeks" because I don't have that much time at the moment.  But I have now been able to take a closer look at your patch and do some tests as well.

The problem due to the missing libraries only occurs if the ports accessibility/speech-dispatcher (for "--enable-tts") and "devel/pkgconf" with "x11-toolkits/gtk30" are already installed, e.g. in a non-poudriere build environment.

A few notes/question:

- Adding "--enable-tts" adds Text-to-Speech support for some engines (and the options dialogues, if enabled).  It requires accessibility/speech-dispatcher which also pulls in audio/pulseaudio which probably not everyone would like this.

Therefore, because this feature is currently not used by so many engines, I would add it as non-default option first to let users choose.  If there is greater demand, it can then be converted into a default one afterwards. 

- Using "--enable-gtk" pulls in around ~600MB an additional dependencies and seems only to be related to the option menu dialogues (slightly different rendering and filebrowser).  Therefore I would rather deactivate the option for now.

- The "--build-all-engines", on the other hand, is nice to test some unstable engines and I would add it as an non-default option as well.  In contrast to "--enable-tts", this option should stay non-default, because those engines are considered as unstable and experimental.

What do you think about it?
Comment 6 Gian-Simon Purkert 2021-06-14 12:20:51 UTC
(In reply to Kai Knoblich from comment #5)

Yes, tts should be a non default option, there is no need to install a behemoth like pulseaudio.

--enable-gtk Absolutely with you on that.

--build-all-engines yes it's good for testing, and if you start a game with a "unstable" engine it gives you a warning anyway.

>Unfortunately, "next days" has become "next weeks"

No hurry, thanks for the reply.
Comment 7 Gian-Simon Purkert 2021-07-04 16:29:21 UTC
Any news?
Comment 8 Kai Knoblich freebsd_committer 2021-07-05 11:15:39 UTC
Created attachment 226233 [details]
scummvm-add-TTS-and-XENGINES-options.patch

Attached is an updated patch which does the following:

- add "--disable-gtk" unconditionally
- add non-default TTS option
- add non-default XENGINES option

(In reply to Gian-Simon Purkert from comment #6)

> --build-all-engines yes it's good for testing, and if you start a game with a "unstable" engine it gives you a warning anyway.

That's right and I've tested this too.  Although it doesn't do much harm when activated, I would still set it as a non-default:

- The output of "scummvm --list-engines" doesn't display which engines are experimental/unstable. IMHO, this would lead to false promises for users that use the official FreeBSD package repository.

For example, one could get the impression that game X is supported and invests some time to collect the required files for game X in order to find out in the end that game X is only roughly supported and not playable at all.

- The "--build-all-engines" option isn't a default option of the "configure" script and has to be set explicitly as it's intended mostly for developers and users which know what they're doing.