Bug 255253 - shells/switchBashZsh: update to version 1.3
Summary: shells/switchBashZsh: update to version 1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://github.com/bourne-again/switc...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-20 09:40 UTC by bourne.identity@hotmail.com
Modified: 2021-04-20 18:46 UTC (History)
1 user (show)

See Also:


Attachments
SVN diff for switchBashZsh v1.3 (983 bytes, patch)
2021-04-20 09:40 UTC, bourne.identity@hotmail.com
bourne.identity: maintainer-approval+
Details | Diff
corrected patch from 1.2.0 to 1.3.0 and without $FreeBSD$ (918 bytes, patch)
2021-04-20 18:36 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bourne.identity@hotmail.com 2021-04-20 09:40:41 UTC
Created attachment 224286 [details]
SVN diff for switchBashZsh v1.3

shells/switchBashZsh has been updated to version 1.3 to fix some minor glitches, mostly in the man page.

svn diff for version 1.3 is attached.

Poudriere/portlint logs available if needed.
Comment 1 Rainer Hurling freebsd_committer 2021-04-20 13:45:24 UTC
Hi,

The ports tree has v1.2 already, and so this update should patch against v1.2, shouldn't it?

And, the ports tree has changed from svn to git and therefore has not $FreeBSD$ tag anymore.

Could you please have a look on your patch?

Rainer
Comment 2 bourne.identity@hotmail.com 2021-04-20 15:48:01 UTC
Yes Rainer, the patch is from version 1.2 to version 1.3.

If ports tree has switched from svn to git, could you be kind enough to provide the set of commands for generating the diff. I have no idea how to checkout the ports tree with git and then change diff format from svn to git.


Thanks for taking this up,
Manish Jain
Comment 3 Rainer Hurling freebsd_committer 2021-04-20 18:36:03 UTC
Created attachment 224305 [details]
corrected patch from 1.2.0 to 1.3.0 and without $FreeBSD$

> Yes Rainer, the patch is from version 1.2 to version 1.3.
The newly attached patch is the version, I tested in Poudriere ;)

> If ports tree has switched from svn to git, could you be
> kind enough to provide the set of commands for generating
> the diff. I have no idea how to checkout the ports tree
> with git and then change diff format from svn to git.
The easiest way to convert a local ports tree for users who are not committers is to move or delete the previous local ports tree and download a new ports tree using git. Good tips on how to do this can be found in [1], for example, but also in many other places on the net.
[1] https://bsdimp.blogspot.com/2020/10/freebsd-git-primer-for-users.html

After the ports tree has been extracted from Git, the changes can be made to the tree. After that, the diff can be created from the root directory of the ports tree as follows:

  git diff shells/switchBashZsh


I strongly recommend to switch the ports tree, also because otherwise there is no current local tree available for patches anymore. The svn based tree was updated for the last time at the end of March and then frozen ;)

My next step will be to commit the patch ...
Comment 4 commit-hook freebsd_committer 2021-04-20 18:45:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e94c43baafc3071329d4c43f2dff96fd22f82ecf

commit e94c43baafc3071329d4c43f2dff96fd22f82ecf
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2021-04-20 18:42:39 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2021-04-20 18:42:39 +0000

    shells/switchBashZsh: Update to 1.3

    Changelog: https://github.com/bourne-again/switchBashZsh/compare/1.2...1.3

    PR:             255253
    Submitted by:   bourne.identity@hotmail.com

 shells/switchBashZsh/Makefile | 2 +-
 shells/switchBashZsh/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Rainer Hurling freebsd_committer 2021-04-20 18:46:25 UTC
Hi Manish,

The patch is committed now :)