Bug 255299 - loader: Fix empty loader_menu_title
Summary: loader: Fix empty loader_menu_title
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-21 10:19 UTC by Jose Luis Duran
Modified: 2021-09-12 05:42 UTC (History)
1 user (show)

See Also:


Attachments
Fix empty loader_menu_title (931 bytes, patch)
2021-04-21 10:19 UTC, Jose Luis Duran
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran 2021-04-21 10:19:27 UTC
Created attachment 224328 [details]
Fix empty loader_menu_title

Commit 62ffcaab8f3ccba6053d4a5622c5ef2de9f636b5 introduced spaces around loader_menu_title.  When set to an empty string (to not display a menu title), the spaces are still displayed.

This patch adds a check to display the menu title only when is not an empty string.
Comment 1 commit-hook freebsd_committer 2021-04-21 11:51:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4ba91fa0736bb0672d475b6b56d9e7b06e78ff69

commit 4ba91fa0736bb0672d475b6b56d9e7b06e78ff69
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2021-04-21 11:42:10 +0000
Commit:     Toomas Soome <tsoome@FreeBSD.org>
CommitDate: 2021-04-21 11:50:23 +0000

    loader: do not output empty menu title

    As we output spaces around the menu title, we should also check,
    if the title is actually empty string.

    PR:             255299
    Submitted by:   Jose Luis Duran
    Reported by:    Jose Luis Duran
    MFC after:      1 week

 stand/forth/menu.4th | 6 +++++-
 stand/lua/drawer.lua | 5 ++++-
 2 files changed, 9 insertions(+), 2 deletions(-)
Comment 2 Toomas Soome freebsd_committer 2021-04-21 11:56:22 UTC
(In reply to Jose Luis Duran from comment #0)

Thank you!
Comment 3 commit-hook freebsd_committer 2021-04-28 09:36:54 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=eabfffcb4c14751d1d2852ed82a1976b69854166

commit eabfffcb4c14751d1d2852ed82a1976b69854166
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2021-04-21 11:42:10 +0000
Commit:     Toomas Soome <tsoome@FreeBSD.org>
CommitDate: 2021-04-28 09:35:54 +0000

    loader: do not output empty menu title

    As we output spaces around the menu title, we should also check,
    if the title is actually empty string.

    PR:             255299
    Submitted by:   Jose Luis Duran
    Reported by:    Jose Luis Duran

    (cherry picked from 4ba91fa0736bb0672d475b6b56d9e7b06e78ff69)

 stand/forth/menu.4th | 6 +++++-
 stand/lua/drawer.lua | 5 ++++-
 2 files changed, 9 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer 2021-09-12 05:42:40 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ea03e7dbeea0d8287b83fb6f8e3c68e81abeba18

commit ea03e7dbeea0d8287b83fb6f8e3c68e81abeba18
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2021-04-21 11:42:10 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2021-09-12 05:39:19 +0000

    loader: do not output empty menu title

    As we output spaces around the menu title, we should also check,
    if the title is actually empty string.

    PR:             255299
    Submitted by:   Jose Luis Duran
    Reported by:    Jose Luis Duran

    (cherry picked from commit 4ba91fa0736bb0672d475b6b56d9e7b06e78ff69)

 stand/forth/menu.4th | 6 +++++-
 stand/lua/drawer.lua | 5 ++++-
 2 files changed, 9 insertions(+), 2 deletions(-)