Bug 255345 - shells/fish: Update to 3.2.2
Summary: shells/fish: Update to 3.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lewis Cook
URL: https://github.com/fish-shell/fish-sh...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-23 14:03 UTC by Lewis Cook
Modified: 2021-04-24 01:19 UTC (History)
1 user (show)

See Also:
asomers: maintainer-feedback+
koobs: merge-quarterly+

Attachments
fish-3.2.2.diff (841 bytes, patch)
2021-04-23 14:03 UTC, Lewis Cook 		lcook: maintainer-approval? (asomers)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2021-04-23 14:03:58 UTC 
Created attachment 224376 [details]
fish-3.2.2.diff

As mentioned in the release notes, this is a bugfix release
and will require an MFH to 2021Q2.

Built and tested in:
releng-114-amd64
releng-114-i386
releng-122-amd64
releng-122-i386
releng-130-amd64
releng-130-i386
Comment 1 Alan Somers freebsd_committer freebsd_triage 2021-04-23 14:11:39 UTC 
The issues in the release notes sound very minor.  Why do you think it needs an MFH?
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2021-04-23 14:26:15 UTC 
(In reply to Alan Somers from comment #1)
Typically bugfix updates assuming that there's not a huge disparity from quarterly (which is not the case, we are jumping from 3.2.1 to 3.2.2) are merged back.  Albeit small fixes, I see no reason _not_ to shoehorn the changes back to 2021Q2 (at the very least, we catch the outliers who experience these bugs).  The release notes do not indicate a major behavioural or feature change, so it's a pretty low-risk MFH.  Your call :)
Comment 3 Alan Somers freebsd_committer freebsd_triage 2021-04-23 14:49:40 UTC 
Well, the patch looks good to me.  But I'm not a ports committer, so I can't approve a MFH.
Comment 4 Lewis Cook freebsd_committer freebsd_triage 2021-04-23 15:02:57 UTC 
(In reply to Alan Somers from comment #3)
No problem, I'll take care of that. :)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-04-23 15:08:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=93946d8aaafcff4fe8142ad4b0abb57af426144c

commit 93946d8aaafcff4fe8142ad4b0abb57af426144c
Author:     Lewis Cook <lcook@FreeBSD.org>
AuthorDate: 2021-04-23 15:03:32 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2021-04-23 15:07:19 +0000

    shells/fish: Update to 3.2.2

    Changes:        https://github.com/fish-shell/fish-shell/releases/tag/3.2.2
    PR:             255345
    Approved by:    asomers (maintainer)
    MFH:            2021Q2

 shells/fish/Makefile | 2 +-
 shells/fish/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 6 Lewis Cook freebsd_committer freebsd_triage 2021-04-23 15:12:30 UTC 
Right, committed and MFH'd in https://cgit.freebsd.org/ports/commit/?h=2021Q2&id=0854e2520786948b8ed964f8711e1889d98d881a. Cheers!
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-04-24 01:18:49 UTC 
(In reply to Alan Somers from comment #3)

MFH no longer requires approval
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2021-04-24 01:19:19 UTC 
^Triage:

 - Assign to committer that resolved
 - Track merge to quarterly