Bug 255483 - security/bitwarden_rs Update to 1.20
Summary: security/bitwarden_rs Update to 1.20
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Michael Reifenberger
Depends on:
Reported: 2021-04-29 13:20 UTC by Adrien
Modified: 2021-05-15 19:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mr)

patch diff (32.31 KB, patch)
2021-04-29 13:20 UTC, Adrien
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien 2021-04-29 13:20:52 UTC
Created attachment 224525 [details]
patch diff

Updated to 2.19.0b. Depreciation of port soon due to renaming of the project.
Comment 1 Marek 2021-05-11 20:43:28 UTC
Hi Michael,

Strange... I can't see this ``security/bitwarden_rs'' upgrade patch in my 13.0-RELEASE box ports tree.
There's 1.9.0_2 version determined by ``lang/rust-1.52'' upgrade as of today (https://www.freshports.org/security/bitwarden_rs/) in the FreeBSD Git repository.
What do you suggest? Apply attached patch, or wait for ``security/vaultwarden'' brand new port in the short future?... :)
There're a lot of significant improvements I'm looking for since 1.9.0 was released :)

Thanks and best regards,
Comment 2 Adrien 2021-05-11 21:28:11 UTC
I'm still waiting for Michael's approval (mr@freebsd.org). It's my first port update so I hope I didn't miss anything 😅. Regarding applying patch, I think you can apply it as last version is 2.19d and this is 2.19b (backup your data/ folder first). I will try to update it to 2.19d ounce I'm sure I've done this one right. 

Comment 3 Marek 2021-05-12 08:09:12 UTC
Hi Adrien,

I'll try your patch a little bit later and report if any issues occur.
Thank you for clarification, hope Michael will approve your work ASAP.

Comment 4 Adrien 2021-05-12 08:19:41 UTC
Great 👍.  I'm running it since last week and no issue so far. Just don't forget to restart the service ounce updated 😁.
Comment 5 Michael Reifenberger freebsd_committer 2021-05-15 15:34:05 UTC
as it seems is 1.19 the last bitwarden_rs version.
1.20 extracts as vaultwarden so your upgrade patch doesnt work.

Comment 6 Adrien 2021-05-15 16:13:15 UTC
(In reply to Michael Reifenberger from comment #5)
If I'm not mistaken 1.20 is the last release under the "bitwarden_rs" name. The new one 1.21 is indeed under vaultwarden. 
I've just tried building it with the patch, and it does work... Only things I've done with this patch is change version number of web vaults (to 2.19b -before vaultwarden rename) as well as change bitwarden_rs version (to 1.20 -before vaultwarden rename as well [28/03/21]) and then update crates dependencies (very long, I haven't found a way to do it other than make the port and adding the crates at every error -must be a dumb way ^^'-)

Best regards,
Comment 7 Adrien 2021-05-15 19:51:56 UTC
So, found that you just need to copy dependencies from cargo.lock on the vaultwarden/bitwarden_rs repo ^^'.
I've updated it to vaultwarden v1.21.0 (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255912). 

Best regards,