Bug 255520 - ports-mgmt/portlint: portlint-2.19.5 report FATAL of comment section
Summary: ports-mgmt/portlint: portlint-2.19.5 report FATAL of comment section
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-30 21:33 UTC by Tatsuki Makino
Modified: 2021-05-04 12:59 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
patch (1.80 KB, patch)
2021-05-01 06:21 UTC, Fukang Chen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2021-04-30 21:33:07 UTC
After $FreeBSD$ is removed, the Makefile with PORTNAME on the 1st line will have FATAL about the section.

Example from multimedia/libopenshot
> portlint /usr/ports/multimedia/libopenshot/
FATAL: Makefile: non-comment line in comment section.
FATAL: Makefile: extra item "MAINTAINER" placed in the PORTNAME section.
FATAL: Makefile: extra item "COMMENT" placed in the PORTNAME section.
FATAL: Makefile: PORTNAME has to be there.
WARN: Makefile: PORTVERSION/DISTVERSION is set externally to this port's Makefile, but this port is not configured as a slave port.
WARN: Makefile: CATEGORIES is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "LICENSE" placed in the MAINTAINER section.
FATAL: Makefile: extra item "LICENSE_FILE" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "BUILD_DEPENDS" placed in the LICENSE section.
FATAL: Makefile: extra item "LIB_DEPENDS" placed in the LICENSE section.
8 fatal errors and 3 warnings found.

Makefiles with the comment "created by" do not cause problems.

Example from astro/geographiclib
> portlint /usr/ports/astro/geographiclib/
looks fine.
Comment 1 Fukang Chen freebsd_committer 2021-05-01 06:21:11 UTC
Created attachment 224586 [details]
patch

- checks if there's a comment section
- comment out some $rcsidstr errors
Comment 2 Jason W. Bacon freebsd_committer 2021-05-04 12:59:33 UTC
I've been seeing the same issue for the past week or so.

The workaround is adding a comment on line 1 without $FreeBSD$, e.g.

# Created by: Name <email>

But then this has to be removed before commit.