Bug 255550 - devel/meson: update to 0.58.1
Summary: devel/meson: update to 0.58.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://mesonbuild.com/Release-notes-...
Keywords: needs-qa, patch
Depends on: 253525
Blocks: 257260
  Show dependency tree / graph
 
Reported: 2021-05-02 15:20 UTC by Jan Beich
Modified: 2021-07-19 03:23 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+
antoine: exp-run+

Attachments
v1 (0.58.0) (4.12 KB, patch)
2021-05-02 15:20 UTC, Jan Beich 		no flags Details | Diff
v2 (0.58.1) (4.15 KB, patch)
2021-06-07 18:37 UTC, Jan Beich 		no flags Details | Diff
v3 (0.58.1) (6.42 KB, patch)
2021-06-08 11:28 UTC, Jan Beich 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2021-05-02 15:20:05 UTC 
Created attachment 224613 [details]
v1 (0.58.0)

See URL for notable changes.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-05-02 20:15:06 UTC 
lgtm after exp-run.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2021-05-04 10:18:19 UTC 
(In reply to Antoine Brodin from comment #2)
> devel/libvirt
> graphics/libglvnd
> x11-fm/nautilus

Maybe a Meson bug. Reported upstream (link in See Also field).

> audio/musicpd
> audio/ncmpc
> net-im/libnice

Requires patching consumers, see https://github.com/mesonbuild/meson/commit/80c89a650b6f

> multimedia/gstreamer1-transcoder

Maybe a bug in gst-transcoder, see https://github.com/mesonbuild/meson/commit/2fabd4c7dc22

include_directories('gst-libs') no longer looks under build directory i.e., -I_build/gst-libs + -Igst-libs becomes -Igst-libs.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2021-05-04 10:29:48 UTC 
(In reply to Jan Beich from comment #3)
> include_directories('gst-libs') no longer looks under build directory i.e., -I_build/gst-libs + -Igst-libs becomes -Igst-libs.

Nevermind. "make stage" fails because @BUILD_ROOT@ and @SOURCE_ROOT@ are no longer expanded in --cflags when "Running custom install script".
Comment 5 Jan Beich freebsd_committer freebsd_triage 2021-06-07 18:37:32 UTC 
Created attachment 225625 [details]
v2 (0.58.1)

Can you perform exp-run again? At least libglvnd builds fine now.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2021-06-08 11:28:08 UTC 
Created attachment 225633 [details]
v3 (0.58.1)

Can you continue the exp-run? This version fixes audio/ncmpc and net-im/libnice.
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2021-06-09 15:29:04 UTC 
Exp-run looks fine
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-06-09 21:30:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=afb3593eef00caa8b7501362910408e3ddc2ca71

commit afb3593eef00caa8b7501362910408e3ddc2ca71
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-05-02 09:43:08 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-06-09 21:29:24 +0000

    devel/meson: update to 0.58.1

    Changes:        https://mesonbuild.com/Release-notes-for-0-58-0.html
    Reported by:    GitHub (watch releases)
    PR:             255550
    Exp-run by:     antoine
    Approved by:    tcberner

 audio/ncmpc/files/patch-doc_meson.build (new)      | 22 ++++++++++++++++++++
 devel/meson/Makefile                               |  3 +--
 devel/meson/distinfo                               |  6 +++---
 ...tch-mesonbuild_compilers_mixins_clang.py (gone) | 24 ----------------------
 devel/meson/files/patch-run__unittests.py          | 10 ++++-----
 .../files/patch-docs_reference_libnice_meson.build | 17 +++++++++++++++
 6 files changed, 48 insertions(+), 34 deletions(-)