Created attachment 224619 [details] py-prettyprinter-update-dependencies.patch Hi I've been getting a lot of reports from pkg-fallout@ wrt py-prettyprinter build failures. For instance: http://beefy15.nyi.freebsd.org/data/130i386-default/0ae18b07e470/logs/py38-prettyprinter-0.18.0.log The package always fail with the same error: distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner==3.0') This is a weird error since the package builds just fine on my FreeBSD server and even on my FreeBSD laptop. I believe the deps are wrong and haven't been properly updated in bug 255274 (apologies I should have been more careful when reviewing the patch). See attached patch for a proper update of the package dependencies. Please review and merge accordingly. Thanks!
^Triage: Assign bug 255274 committer Ports cannot robustly support == dependencies. They need to be adjusted, ideally upstream in the long-term, to >= dependencies. See: https://wiki.freebsd.org/Python/PortsPolicy#Dependencies
Sure, LGTM. Who should commit, me or koobs@.
NVM, I'll commit.
Modifying *_DEPENDS is insufficient. *_DEPENDS lines *must* match (exactly) those defined in the upstream package metadata, or that metadata needs to be modified (eg: s/==/>=) However, when modifying upstream dependency version specs, extensive QA must be run (test suites especially) to ensure they work correctly with other/later/different versions. These version spec issues and changes should be sent upstream for correct and permanent resolution
Created attachment 224625 [details] Proposed patch for fixing the build I have a proposed patch which removes the hard dependency on pytest-runner==3.0. This passes poudriere tests.
(In reply to Neel Chauhan from comment #5) Hi! Feel free to go ahead and apply whatever patch which solves this problem. I don't have your expertise on the matter! ;)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=46ee17ded040af73e358ad2c15d84a39728c3b32 commit 46ee17ded040af73e358ad2c15d84a39728c3b32 Author: Neel Chauhan <nc@FreeBSD.org> AuthorDate: 2021-05-04 16:27:53 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2021-05-04 16:29:12 +0000 devel/py-prettyprinter: Fix pytest-runner dependency PR: 255555 Reported by: Patrice Clement <monsieurp@gentoo.org> (maintainer) devel/py-prettyprinter/files/patch-setup.py (new) | 11 +++++++++++ 1 file changed, 11 insertions(+)
Committed! I don't think this needs to be merged into quarterly since 2021Q2 still has the old version.
MFH: No (quarterly unaffected)
Hi! I keep getting emails from pkg-fallout@ even after the latest fix. See http://beefy9.nyi.freebsd.org/data/114amd64-default/e67ae562eb4c/logs/py38-prettyprinter-0.18.0.log ! :(
This is/was a runtime failure and the commit didn't bump the PORTREVISION, so the port was not rebuilt
Committed!
@koobs thanks for pointing out. Sorry for too many messages.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=44eddfbf64c56fe74c4fe0aa843a5004aab54134 commit 44eddfbf64c56fe74c4fe0aa843a5004aab54134 Author: Neel Chauhan <nc@FreeBSD.org> AuthorDate: 2021-05-06 01:15:19 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2021-05-06 01:15:19 +0000 devel/py-prettyprinter: Bump PORTREVISION This allows the port to be rebuilt as per the fix in commit 46ee17ded040af73e358ad2c15d84a39728c3b32. PR: 255555 devel/py-prettyprinter/Makefile | 1 + 1 file changed, 1 insertion(+)