Bug 255587 - lang/v8: Fails to Build after devel/gn update
Summary: lang/v8: Fails to Build after devel/gn update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-04 09:07 UTC by Adam Strohl
Modified: 2021-05-20 17:19 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Full Poudriere Log (20.40 KB, text/plain)
2021-05-04 09:07 UTC, Adam Strohl
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Strohl 2021-05-04 09:07:49 UTC
Created attachment 224655 [details]
Full Poudriere Log

Tested under both Poudriere and directly under ports, same error during config:

ERROR at //build/win/BUILD.gn:14:1: Unknown function.
set_sources_assignment_filter(deprecated_default_sources_assignment_filter)
^----------------------------
See //BUILD.gn:4453:5: which caused the file to be included.
    "//build/win:default_exe_manifest",

Been this way for a week or two, thought it might just be some fluke but confirmed under clean ports now too.
Comment 1 John W. O'Brien 2021-05-08 22:41:51 UTC
When I roll devel/gn back to v1823 (prior to 2021-04-24 [0]), the lang/v8 build succeeds.

# cd /usr/ports/devel/gn
# git checkout 0eaae11a7b886f626b8a491e644cd47ddf5403cb^ -- .

The statement that "GN expects that the project choose the appropriate version of GN that will work with each version of the project. There is no 'current stable version' of GN that is expected to work for all projects." [1] is disheartening from a package maintainer's perspective.


[0] https://cgit.freebsd.org/ports/commit/devel/gn?id=0eaae11a7b886f626b8a491e644cd47ddf5403cb
[1] https://github.com/cglogic/gn/tree/v1897#versioning-and-distribution
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2021-05-09 11:25:00 UTC
You can safely remove set_sources_assignment_filter in build/win/BUILD.gn (and maybe in some other files)
Comment 3 Oleh Hushchenkov 2021-05-09 13:57:27 UTC
This is not specific for FreeBSD 12.2.

Commit: https://gn.googlesource.com/gn/+/55e535a6716e57320fdd3901f0347a5c30562199
> Remove `set_sources_assignment_filter` function
> The function has been deprecated since Oct 2020, only accepting an
> empty list. All projects using it should have been converted. If
> any break, they can just remove the function call.

https://chromium.googlesource.com/v8/v8.git show that there are new versions: 8.8, 8.9, 9.0, 9.1, 9.2. Updating v8 should fix the issue.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-05-09 16:20:38 UTC
This failure was caused by devel/gn update (0eaae11a7b886f626b8a491e644cd47ddf5403cb).

FYI, I'm working on the v8 9.0.257.23 update.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-05-11 21:56:37 UTC
FYI, I've committed v8 9.0.257.23 in 4b783f69ff097b9008ff177d3946004cbddf176d. It should fix the problem.