Bug 255592 - graphics/gdal: Uses EXR option, even if disabled, if OpenEXR is present
Summary: graphics/gdal: Uses EXR option, even if disabled, if OpenEXR is present
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-04 12:27 UTC by Rainer Hurling
Modified: 2021-05-04 21:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Patch to fix disabling option EXR (518 bytes, patch)
2021-05-04 12:27 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer 2021-05-04 12:27:45 UTC
Created attachment 224659 [details]
Patch to fix disabling option EXR

In a discussion on ports@ LuMiWa <lumiwa@dismail.de> (02.05.2021, 19:55) presented a breakage in the build of graphics/gdal, if option EXR is disabled, but graphics/openexr is present on the system.

The Makefile uses EXR_CONFIGURE_ON=--with-exr, so this switch is not suppressed if the option is deselected.

If EXR_CONFIGURE_WITH=exr is used instead, --with-exr is not used in the configure script if the option is deselected.

The attached patch contains the corresponding change ;)
Comment 1 commit-hook freebsd_committer 2021-05-04 21:51:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=23746f91b756086b6c7b798e9ae6531c8c9a4e3c

commit 23746f91b756086b6c7b798e9ae6531c8c9a4e3c
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2021-05-04 21:44:20 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2021-05-04 21:45:48 +0000

    graphics/gdal: Fix EXR option

    PR:             255592

 graphics/gdal/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Po-Chuan Hsieh freebsd_committer 2021-05-04 21:51:34 UTC
Committed. Thanks!