Bug 255620 - deskutils/calibre: crashes opening markdown file
Summary: deskutils/calibre: crashes opening markdown file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-05 14:58 UTC by waitman
Modified: 2021-05-06 20:24 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description waitman 2021-05-05 14:58:10 UTC
Crashes with message complaining about missing cchardet module.


Port Makefile has runtime dependency of chardet, should also include cchardet

RUN_DEPENDS=
...

${PYTHON_PKGNAMEPREFIX}chardet>=0:textproc/py-chardet@${PY_FLAVOR} \
${PYTHON_PKGNAMEPREFIX}cchardet>=0:textproc/py-cchardet@${PY_FLAVOR} \
...

py38-chardet Universal encoding detector for Python 2 and 3
py38-cchardet High speed universal character encoding detector

Installing cchardet resolves the issue.
Comment 1 Guido Falsi freebsd_committer 2021-05-05 15:11:25 UTC
Thanks for reporting this. I'm going to apply the suggested change soon.
Comment 2 commit-hook freebsd_committer 2021-05-06 20:19:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=99620e82296e7e4ae7228f4d31f714c9408ea793

commit 99620e82296e7e4ae7228f4d31f714c9408ea793
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-05-06 20:17:08 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-05-06 20:18:53 +0000

    deskutils/calibre: Add missing dependency

    Add a dependency dynamically used to open markdown files.

    PR:             255620

 deskutils/calibre/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer 2021-05-06 20:23:34 UTC
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9bb7cf5c6f719b3266b85d85bba496f3e2011264

commit 9bb7cf5c6f719b3266b85d85bba496f3e2011264
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-05-06 20:17:08 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-05-06 20:22:24 +0000

    deskutils/calibre: Add missing dependency

    Add a dependency dynamically used to open markdown files.

    PR:             255620
    (cherry picked from commit 99620e82296e7e4ae7228f4d31f714c9408ea793)

 deskutils/calibre/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 Guido Falsi freebsd_committer 2021-05-06 20:24:38 UTC
Fix committed and merged to quarterly. Thanks!