Bug 255627 - x11-fonts/tkfont: add LICENSE, take MAINTAINER
Summary: x11-fonts/tkfont: add LICENSE, take MAINTAINER
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-05 18:51 UTC by Chris Hutchinson
Modified: 2021-05-06 15:42 UTC (History)
1 user (show)

See Also:


Attachments
patch for x11-fonts/tkfont (431 bytes, patch)
2021-05-05 18:51 UTC, Chris Hutchinson
no flags Details | Diff
x11-fonts/tkfont: correction for previous commit (431 bytes, patch)
2021-05-06 15:08 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2021-05-05 18:51:10 UTC
Created attachment 224700 [details]
patch for x11-fonts/tkfont

The patch attached to this pr(1) simply
adds a LICENSE. While here assign MAINTAINER to me.

Changes
LICENSE    (adds)
MAINTAINER (from ports@ to me)

That's it!

Thanks! :-)

--Chris

NOTE: this port is currently maintained by ports@
so approval is implicit
Comment 1 Neel Chauhan freebsd_committer 2021-05-06 01:22:39 UTC
Committed!
Comment 2 commit-hook freebsd_committer 2021-05-06 01:23:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3601afa06bca348158b9cb5dbe1bdf4b3a7e0156

commit 3601afa06bca348158b9cb5dbe1bdf4b3a7e0156
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2021-05-06 01:22:09 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-05-06 01:22:09 +0000

    x11-fonts/tkfont: add LICENSE and pass maintainership to submitter

    PR:     255627

 x11-fonts/tkfont/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 3 Tobias Kortkamp freebsd_committer 2021-05-06 08:15:52 UTC
The patch has 'license' not 'LICENSE'. The commit has the same mistake.
Case matters.

$ make check-sanity
/!\ tkfont-1.1_3: Makefile warnings, please consider fixing /!\

Please set LICENSE for this port
Comment 4 Chris Hutchinson 2021-05-06 15:08:47 UTC
Created attachment 224728 [details]
x11-fonts/tkfont: correction for previous commit

> The patch has 'license' not 'LICENSE'. The commit has the same mistake.
Good catch!
Thank you! :-)
I tested the change in a jail. Then (mistakenly) duplicated
the tkfont directories for the diff(1) and diffed from there.
I apparently hit the CAPSLOCK looking for auto-complete. :-(

Thanks again!

The attached patch IS correct now.

--Chris
Comment 5 commit-hook freebsd_committer 2021-05-06 15:42:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c0bb8b8d52fbd93b6ff8deec5215c32621420a0

commit 3c0bb8b8d52fbd93b6ff8deec5215c32621420a0
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2021-05-06 15:42:15 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-05-06 15:42:15 +0000

    x11-fonts/tkfont: Use correct case for LICENSE

    PR:     255627

 x11-fonts/tkfont/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Neel Chauhan freebsd_committer 2021-05-06 15:42:51 UTC
Committed the fix!