Bug 255630 - cad/cura: Update to 4.12.1
Summary: cad/cura: Update to 4.12.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Diane Bruce
URL: https://github.com/Ultimaker/Cura/rel...
Keywords: needs-qa
Depends on: 255237
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-05 19:26 UTC by Val Packett
Modified: 2022-08-05 00:14 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (db)


Attachments
cura-490.patch (390.83 KB, patch)
2021-05-05 19:28 UTC, Val Packett
no flags Details | Diff
cura-490.patch (390.83 KB, patch)
2021-07-29 12:12 UTC, Val Packett
no flags Details | Diff
cura-4110.patch (265.21 KB, patch)
2021-09-29 06:18 UTC, Matthieu Volat
no flags Details | Diff
revised patch with the latest ports tree (307.18 KB, patch)
2021-10-18 01:48 UTC, Tomoyuki Sakurai
no flags Details | Diff
0001-cad-cura-update-to-4.12.1-https-bugs.freebsd.org-bug.patch (290.70 KB, patch)
2022-01-31 18:07 UTC, Val Packett
koobs: maintainer-approval? (trombik1973)
Details | Diff
update to 4.13.1 (330.49 KB, patch)
2022-02-26 00:56 UTC, Tomoyuki Sakurai
no flags Details | Diff
with OpenMP disabled (330.75 KB, patch)
2022-02-27 01:09 UTC, Tomoyuki Sakurai
no flags Details | Diff
cura 4.13.1 (332.29 KB, patch)
2022-04-28 09:26 UTC, Tomoyuki Sakurai
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2021-05-05 19:26:46 UTC
Relnotes: https://github.com/Ultimaker/Cura/releases/tag/4.9.0

Fix not even exactly mentioned in relnotes: Bridge Fan Speed actually works now, instead of always disabling the fan on detected bridges :D

Port changes: removed git hashes where tags exist; commented out systemd unit.

Weirdness note: pynest2d doesn't have a 4.9.0, so the current commit on the 4.9-beta branch is used.

New dependency: py-keyring. Hopefully didn't miss any others.
Comment 1 Val Packett 2021-05-05 19:28:20 UTC
Created attachment 224702 [details]
cura-490.patch

actual patch lol
Comment 2 Diane Bruce freebsd_committer freebsd_triage 2021-05-14 15:03:32 UTC
Working on this this weekend.
Comment 3 Matthieu Volat 2021-07-03 06:07:08 UTC
Hi, any progress on reviewing this upgrade? I tried it without seeing any issue, and it's really cool to have Cura in ports!
Comment 4 Val Packett 2021-07-29 12:12:54 UTC
Created attachment 226775 [details]
cura-490.patch

Regenerated patch after various portrevision bumps.
Comment 5 Steve Wills freebsd_committer freebsd_triage 2021-08-16 14:27:24 UTC
It seems the new cura won't run properly with old py-keyring
Comment 6 Matthieu Volat 2021-09-29 06:18:46 UTC
Created attachment 228237 [details]
cura-4110.patch

Hi, it is a bit sad to see this PR going stale while two other Cura version have been released, I was happy to be able to use Cura in FreeBSD :)

Since the original reporter did not push updates, I would like to propose mine which brings cura to 4.11.0.

Nothing really special to report there, it basically touch the same ports as the 4.9.0 update(cad/cura-engine cad/fdm_materials cad/uranium devel/py-pynest2d net/libarcus net/libcharon) and most of the job was to update the pkg-plist files based on makeplist.

Here some check-plist testing:

gramr:/usr/ports# for port in cad/cura-engine cad/fdm_materials cad/uranium devel/py-pynest2d net/libarcus net/libcharon; do echo "=========== $port ==========="; make -C $port check-plist; done
=========== cad/cura-engine ===========
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=========== cad/fdm_materials ===========
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=========== cad/uranium ===========
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=========== devel/py-pynest2d ===========
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=========== net/libarcus ===========
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=========== net/libcharon ===========
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

As for actually using the port, I've tried some splicing and octoprint-based printing without any issue.

Thanks if somebody can have a look and feedback on this.

Regards
Comment 7 Diane Bruce freebsd_committer freebsd_triage 2021-10-02 23:44:45 UTC
I'll start work on this tonight.
Comment 8 Diane Bruce freebsd_committer freebsd_triage 2021-10-03 14:25:48 UTC
Looks like I got interrupted with real life during test of the Cura 4.9 update as I was sure I had committed that.  Sorry :-(

Looking at 4.11 diffs they work great but py-pynest2d Maintainer is y@trombik.org so he'll also have to approve.
Comment 9 Tomoyuki Sakurai 2021-10-12 01:56:15 UTC
(In reply to Diane Bruce from comment #8)

the maintainer of py-pynest2d here. the port was introduced as a new dependency while updating cura. IMO, all these cura-related ports, such as libarcus, should be managed by a single maintainer because they must be updated at the same time. in theory, other applications may depend on them, but i don't know other consumers.

please reset my MAINTAINER in py-pynest2d. thanks.
Comment 10 Val Packett 2021-10-15 20:26:04 UTC
I've had to delete patch-CMakeLists.txt in pynest2d in addition to applying the patch, but 4.11 is working great :)
Comment 11 Tomoyuki Sakurai 2021-10-18 01:45:38 UTC
the patches, `cura-490.patch` and `cura-4110.patch`, are stale. also, errors and warnings are logged in `poudriere` build.
Comment 12 Tomoyuki Sakurai 2021-10-18 01:48:09 UTC
Created attachment 228794 [details]
revised patch with the latest ports tree

also fixes missing `gettext-runtime` dependency.
Comment 13 Tomoyuki Sakurai 2021-10-18 02:03:13 UTC
I would like to call for help and contributions from those who want up-to-date `cura`. as I see it, the maintainer has been busy, and maintaining `cura` and its dependencies is not a trivial task. the traditional workflow in bugzilla is not very suitable for collaboration. here is my partial ports tree to maintain `cura`.

https://github.com/trombik/freebsd-ports-cura

If you want to help, read "Maintaining cura ports" in the Wiki, follow the steps, and report the result in `Issues`.

https://github.com/trombik/freebsd-ports-cura/wiki/Maintaining-cura-ports

If you don't have a working `poudriere`, then, merge the partial ports tree into your own ports tree, and built by hand. Install and use `cura`, print something, and report the result in `Issues`.

In a typical workflow, a PR is made when the partial ports tree has been tested.

This way, the MAINTAINER just need to approve the PR. some other ports, like `drm-current-kmod`, also use a workflow like this.
Comment 14 Val Packett 2022-01-31 18:06:20 UTC
pynest2d and libarcus were just updated to 4.12.x by some pyqt-related commit!
Comment 15 Val Packett 2022-01-31 18:07:25 UTC
Created attachment 231471 [details]
0001-cad-cura-update-to-4.12.1-https-bugs.freebsd.org-bug.patch

So here's 4.12.1, with the requested maintainer changes and the gettext thing.
Comment 16 Diane Bruce freebsd_committer freebsd_triage 2022-02-01 13:58:12 UTC
Much apologies all. Correct I have been busy. :-( The ideal here I think
would be a cad group to keep on top of these things. I have been
hammering away on other ports and will get this into the tree ASAP.
Comment 17 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-03 00:23:30 UTC
Comment on attachment 231471 [details]
0001-cad-cura-update-to-4.12.1-https-bugs.freebsd.org-bug.patch

^Triage: Request approval from devel/libnest2d-ultimaker maintainer. We have
implicit (reset maintainer request) in comment 9 for devel/py-pynest2d, but not
yet for devel/libnest2d-ultimaker

@Tomoyuki Also note that your current Bugzilla email does not match the port MAINTAINER lines. How should we proceed? 

1) You may update your Bugzilla email to match MAINTAINER, or 
2) Diane may update your MAINTAINER lines to match Bugzilla, or
3) We can reset MAINTAINER
Comment 18 Tomoyuki Sakurai 2022-02-03 08:48:57 UTC
(In reply to Kubilay Kocak from comment #17)

please reset MAINTAINER. the patch does not include my email, and that is what should have been (i'm not yet asking maintainership of the ports).
 
i'm building cad/cura with the patch now, but i have already noticed a bug (DISTVERSION of each ports should be identical, but not).
Comment 19 Tomoyuki Sakurai 2022-02-03 12:27:47 UTC
[03:16:23] [01] [00:02:17] Skipping cad/cura | Cura-4.12.1: Dependent port math/py-networkx | py38-networkx-2.6.3,1 failed

math/py-networkx fails to build because of qhull8 and qhull7 conflict in the dependency.

depends on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261279
Comment 20 Tomoyuki Sakurai 2022-02-26 00:56:22 UTC
Created attachment 232115 [details]
update to 4.13.1

built fine with poudriere and the latest ports on CURRENT.
Comment 21 Tomoyuki Sakurai 2022-02-26 06:05:29 UTC
the CuraEngine has an issue on my CURRENT. the first slice just works, but subsequent slices do not. the process hangs.
Comment 22 Tomoyuki Sakurai 2022-02-26 06:23:10 UTC
according to a PR, OpenMP will be replaced.

https://github.com/Ultimaker/CuraEngine/pull/1524

i'll disable OpenMP for now.
Comment 23 Tomoyuki Sakurai 2022-02-27 01:09:16 UTC
Created attachment 232129 [details]
with OpenMP disabled
Comment 24 Tomoyuki Sakurai 2022-04-28 09:26:22 UTC
Created attachment 233557 [details]
cura 4.13.1

bugfix: net/libarcus fix a crash with newer protocol-buffers 

https://github.com/trombik/freebsd-ports-cura/commit/11a0e5c0b80d05f61d3fa68e4ca5053f64c7ef50

bugfix: cad/cura remove NoKeyringError from import
https://github.com/trombik/freebsd-ports-cura/commit/8d5d2ccd98ceb854e1f2d5004706e161a69d18a9
Comment 25 Diane Bruce freebsd_committer freebsd_triage 2022-08-04 22:14:54 UTC
This port has been sitting here. Apologies as the port has been frustrating. I will take another look this weekend.
Comment 26 commit-hook freebsd_committer freebsd_triage 2022-08-04 23:00:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0628704aae0c4d91e325b2d7d53dab04bcd2769a

commit 0628704aae0c4d91e325b2d7d53dab04bcd2769a
Author:     Diane Bruce <db@FreeBSD.org>
AuthorDate: 2022-08-04 22:52:04 +0000
Commit:     Diane Bruce <db@FreeBSD.org>
CommitDate: 2022-08-04 22:52:04 +0000

    ports/cura: Update to 4.13.1

    Major update to 4.13.1 not 4.12
    I've said it before and I'll say it again. This port should be a
    group effort but a cads porting team. I'd be happy to give
    up Maintainership as my only interest with cura was to get it into
    ports.

    PR:             ports/255630
    Reported by:    unrelentingtech <greg@unrelenting.technology>
    Tested by:      trombik1973@gmail.com

 cad/cura-engine/Makefile                           |    8 +-
 cad/cura-engine/distinfo                           |    6 +-
 cad/cura-engine/files/patch-CMakeLists.txt (new)   |   19 +
 cad/cura-engine/files/patch-src_support.cpp        |    4 +-
 cad/cura/Makefile                                  |   15 +-
 cad/cura/distinfo                                  |    6 +-
 .../patch-cura_OAuth2_KeyringAttribute.py (new)    |   11 +
 cad/cura/files/patch-cura__app.py                  |    4 +-
 cad/cura/pkg-plist                                 | 2750 ++++++++++++++++++--
 cad/uranium/Makefile                               |    4 +-
 cad/uranium/distinfo                               |    6 +-
 cad/uranium/pkg-plist                              |   70 +-
 devel/libnest2d-ultimaker/Makefile                 |   12 +-
 devel/libnest2d-ultimaker/distinfo                 |    6 +-
 devel/libsavitar/Makefile                          |    4 +-
 devel/libsavitar/distinfo                          |    6 +-
 devel/py-pynest2d/Makefile                         |    8 +-
 devel/py-pynest2d/distinfo                         |    6 +-
 net/libarcus/Makefile                              |    3 +-
 net/libarcus/distinfo                              |    6 +-
 .../{patch-protobuf => patch-src_Socket__p.h}      |    6 +-
 net/libcharon/Makefile                             |    5 +-
 net/libcharon/distinfo                             |    6 +-
 net/libcharon/pkg-plist                            |    3 +-
 24 files changed, 2617 insertions(+), 357 deletions(-)
Comment 27 Tomoyuki Sakurai 2022-08-05 00:14:53 UTC
Diane, thanks for your efforts.

instead of `cad` project, i would like to suggest `makers` instead. there are many makers-related ports, apparently with a small user base. examples are: cura, kicad, arduino, and toolchains for MCUs.

as i see it, there are no solid rules to form a project (some have a list, some do not).

if anyone would like to contribute the efforts, instead of complaining, my ports repositories are open to contributions. if there are enough interests and people who help the efforts, i will officially propose the project. otherwise, i will maintain the repositories just for myself as before.
 
https://github.com/trombik?tab=repositories&q=freebsd-ports