Bug 255724 - [NEW PORT] x11-themes/chicago95: Classic Redmond theme
Summary: [NEW PORT] x11-themes/chicago95: Classic Redmond theme
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL: https://github.com/grassmunk/Chicago95
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-05-09 13:22 UTC by Evgeniy Khramtsov
Modified: 2021-05-10 16:17 UTC (History)
3 users (show)

See Also:
evgeniy: maintainer-feedback+


Attachments
compressed diff (53.48 KB, patch)
2021-05-09 13:23 UTC, Evgeniy Khramtsov
no flags Details | Diff
patch with autoplist and entry for new port (2.84 KB, patch)
2021-05-10 06:09 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Khramtsov 2021-05-09 13:22:38 UTC
Chicago95 is a theme rendition of classic 1995 Microsoft operating system.
It includes various backgrounds, themes, and icons for consistent look.

WWW: https://github.com/grassmunk/Chicago95
Comment 1 Evgeniy Khramtsov 2021-05-09 13:23:57 UTC
Created attachment 224790 [details]
compressed diff

Hit Bugzilla patch size limit, here is compressed diff.

Don't forget to add to x11-themes/Makefile, I did diff as described in "3.6. Submitting the New Port".
Comment 2 Neel Chauhan freebsd_committer 2021-05-10 01:30:14 UTC
Which tool did you use to compress the diff? I could not uncompress it with gzip, bzip2, xz, or zip.

As mentioned in Chapter 11 of the Porters Handbook, it says:

    Do not compress or encode the diff

https://docs.freebsd.org/en/books/porters-handbook/upgrading/

If the diff is too big, a site like Mediafire or Google Drive, or your own web server if you have one, makes more sense to upload the diff to.
Comment 3 Evgeniy Khramtsov 2021-05-10 05:15:41 UTC
(In reply to Neel Chauhan from comment #2)

zstd(1):

$ file 'attachment.cgi?id=224790'
attachment.cgi?id=224790: Zstandard compressed data (v0.8+), Dictionary ID: None

$ zstd -d 'attachment.cgi?id=224790' -o diff

$ file diff
diff: unified diff output, ASCII text

> Do not compress or encode the diff

Bugzilla did not warn that the attachment is too big; the file MIME type was also lost when the checkbox 'patch' was ticked. When I had this bug filed, I wanted to add the attachment ASAP to not confuse a reader with bug filed without a patch. Sorry, next time I won't.
Comment 4 Rainer Hurling freebsd_committer 2021-05-10 06:09:27 UTC
Created attachment 224803 [details]
patch with autoplist and entry for new port

Hi Neel, hi Evgeniy,

You can easily uncompress attachment 224790 [details] with /usr/bin/unzstd ;)


Since the pkg-plist is _very_ long and large, there is an alternative, as yuri@ pointed out on ports-committers@ after I asked for it.

In the attached new patch (git diff, uncompressed) an 'autoplist' is created in the post-install target. I find this solution quite elegant.

The patch also contains the missing entry for the new port in x11-themes/Makefile.
Comment 5 Rainer Hurling freebsd_committer 2021-05-10 10:37:17 UTC
(In reply to Rainer Hurling from comment #4)

I may not have given good advice there. Anyway, on ports-committers@ it is just argued that debugging with autoplists is hardly possible. So probably rather the long pkg-plist?
Comment 6 Evgeniy Khramtsov 2021-05-10 12:21:18 UTC
(In reply to Rainer Hurling from comment #5)

Hi Rainer,

Thanks for this patch. I've tested it with poudriere testport: all options and inverted options (BACKGROUNDS=off CURSORS=off ICONS=off) are OK.

I think it is the best way; I doubt someone needs to grep for some files before installing this port, there are no development headers or libraries. The best part of this way, is that the port takes less storage space without the large pkg-plist. The list is still accessible over 'pkg list', of course.

'patch with autoplist and entry for new port' maintainer-feedback+.
Comment 7 Neel Chauhan freebsd_committer 2021-05-10 16:16:49 UTC
Committed!
Comment 8 commit-hook freebsd_committer 2021-05-10 16:17:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=218ad8035b585651aeaaddbcffc2d423b557dde7

commit 218ad8035b585651aeaaddbcffc2d423b557dde7
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-05-10 16:16:11 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-05-10 16:16:11 +0000

    New port: x11-themes/chicago95: Classic Redmond theme

    PR:     255724

 x11-themes/Makefile                  |  1 +
 x11-themes/chicago95/Makefile (new)  | 60 ++++++++++++++++++++++++++++++++++++
 x11-themes/chicago95/distinfo (new)  |  3 ++
 x11-themes/chicago95/pkg-descr (new) |  4 +++
 4 files changed, 68 insertions(+)