Bug 255734 - audio/libvorbis: Switch to CMake to enable config-file packages
Summary: audio/libvorbis: Switch to CMake to enable config-file packages
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christian Weisgerber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-09 21:18 UTC by Daniel Engberg
Modified: 2021-05-14 14:29 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (naddy)


Attachments
Patch for libvorbis (12.30 KB, patch)
2021-05-09 21:18 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg 2021-05-09 21:18:30 UTC
Created attachment 224798 [details]
Patch for libvorbis

Backport CMake fixes from upstream and switch to CMake
PORTVERSION --> DISTVERSION as per Porter's Handbook
Replace downloads.xiph.org with ftp.osuosl.org (redirects) in MASTER_SITES
Don't build static lib(s) (couldn't find any users in ports tree)

Compile tested on 13.0-STABLE #0 stable/13-n245283-70a2e9a3d44 (arm64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Comment 1 Daniel Engberg 2021-05-10 12:44:12 UTC
Patch submitted upstream
https://github.com/xiph/vorbis/pull/82

Reported issue to upstream about Makefiles in docs dir
https://github.com/xiph/vorbis/issues/83
Comment 2 Christian Weisgerber freebsd_committer 2021-05-14 14:29:07 UTC
I disagree with these changes, see PR 255733.