Bug 255755 - make: "/usr/ports.dev/Mk/bsd.port.mk" line 1469: Unclosed .include filename. '"' expected
Summary: make: "/usr/ports.dev/Mk/bsd.port.mk" line 1469: Unclosed .include filename. ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords:
: 255756 255757 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-10 17:03 UTC by Neel Chauhan
Modified: 2021-05-11 10:24 UTC (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2021-05-10 17:03:33 UTC 
When I try to run "make makesum", I get this error:

make: "/usr/ports.dev/Mk/bsd.port.mk" line 1469: Unclosed .include filename. '"' expected

Unless it's my system only, this prevents me from building new ports.

Keep in mind that I develop Ports inside a jail.
Comment 1 Anderson Guzman 2021-05-10 17:28:36 UTC 
Hello guys!, 

We are also affected by this error 


make: "/usr/ports/Mk/bsd.port.mk" line 1469: Unclosed .include filename. '"' expected
make: Fatal errors encountered -- cannot continuemake: "/usr/share/mk/sys.mk" line 201: Unknown modifier ':'
make: "/usr/share/mk/sys.mk" line 213: Unknown modifier ':'
make: Fatal errors encountered -- cannot continueeval: make:: not found
export: make:: bad variable name
Comment 2 Anderson Guzman 2021-05-10 17:31:00 UTC 
(In reply to Anderson Guzman from comment #1)

I forgot to mention, this is a vanilla FreeBSD 13, completely fresh installation

Be safe!
Comment 3 Anderson Guzman 2021-05-10 17:35:06 UTC 
(In reply to Anderson Guzman from comment #2)


The fix is very easy, just add '"' to the line # 1469 on file bsd.port.mk:

orig:

.sinclude "${_overlayfile}

With the typo fix:

.sinclude "${_overlayfile}"

Be safe!
Comment 5 Alan Somers freebsd_committer freebsd_triage 2021-05-10 18:14:02 UTC 
*** Bug 255756 has been marked as a duplicate of this bug. ***
Comment 6 Alan Somers freebsd_committer freebsd_triage 2021-05-10 18:14:16 UTC 
*** Bug 255757 has been marked as a duplicate of this bug. ***
Comment 7 Allan Jude freebsd_committer freebsd_triage 2021-05-10 18:35:44 UTC 
The revert of the offending commit was committed here: https://cgit.freebsd.org/ports/commit/?id=61daf777c5d6ccfd8bfd1287627f7f286759ffa4


Although it looks like the issue was just a missing " on the last line
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-11 10:24:10 UTC 
^Triage: Fixed but PR not referenced. Closing