Bug 255807 - sysutils/lsblk: update to 3.4
Summary: sysutils/lsblk: update to 3.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-12 09:27 UTC by Slawomir Wojciech Wojtczak
Modified: 2021-05-13 06:58 UTC (History)
1 user (show)

See Also:

Attachments
lsblk-3.4.diff (924 bytes, patch)
2021-05-12 10:12 UTC, Slawomir Wojciech Wojtczak 		vermaden: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slawomir Wojciech Wojtczak 2021-05-12 09:27:07 UTC 
Hi,


I would like to update the 'lsblk' port.

With this update I would like to make the FreeBSD port reflect the current lsblk version hence the 1.1 -> 3.4 change.

Below is the diff(1) output.

I was able to install this port using these modified 'Makefile' and 'distinfo' files.

If something more is needed then let me know.



% diff -u -r -N  lsblk lsblk.NEW 
diff -u -r -N lsblk/Makefile lsblk.NEW/Makefile
--- lsblk/Makefile      2021-04-14 22:07:30.766671000 +0200
+++ lsblk.NEW/Makefile  2021-05-12 11:19:08.549489000 +0200
@@ -1,5 +1,5 @@
 PORTNAME=      lsblk
-PORTVERSION=   1.1
+PORTVERSION=   3.4
 CATEGORIES=    sysutils
 MASTER_SITES=  https://github.com/vermaden/lsblk/raw/master/release/
 
@@ -18,3 +18,4 @@
            ${STAGEDIR}${PREFIX}/sbin/${PORTNAME}
 
 .include <bsd.port.mk>
+
diff -u -r -N lsblk/distinfo lsblk.NEW/distinfo
--- lsblk/distinfo      2021-04-14 22:07:30.766776000 +0200
+++ lsblk.NEW/distinfo  2021-05-12 11:20:38.219476000 +0200
@@ -1,3 +1,4 @@
-TIMESTAMP = 1599137521
-SHA256 (lsblk-1.1.tar.gz) = c8cb0a40b5a625903e0660f34916911bb18cb0aca24686283e3373acad63ac43
-SIZE (lsblk-1.1.tar.gz) = 4510
+TIMESTAMP = 1620811083
+SHA256 (lsblk-3.4.tar.gz) = 70ae48e10554ee1589597d974d167d17429eaafe3d48c62f6d1e4e9ff3d7ccab
+SIZE (lsblk-3.4.tar.gz) = 4770
+


Regards.
Comment 1 Slawomir Wojciech Wojtczak 2021-05-12 09:31:35 UTC 
Here is the Changelog if needed:

- Add sysctl -n kern.disks to disk listing.
- Reset LABEL in __gpart_present function.
- Fix behavior with [bootme] and [bootonce] flags from gpart(8).
- Disable GPTID for label display.
- Add -d|--disks option to list entire disks only. 

Regards.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2021-05-12 09:55:21 UTC 
^Triage: Simplifying title

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

You can add the diff as an attachemnt. Then:

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]


Thanks!
Comment 3 Slawomir Wojciech Wojtczak 2021-05-12 10:12:17 UTC 
Created attachment 224866 [details]
lsblk-3.4.diff
Comment 4 Slawomir Wojciech Wojtczak 2021-05-12 10:13:10 UTC 
(In reply to Fernando Apesteguía from comment #2)
Ignore the Changelog. Added attachemnt. Added '+' to 'maintainer-approval'.
Comment 5 Slawomir Wojciech Wojtczak 2021-05-12 17:59:12 UTC 
Is that attached patch sufficient for that port update?
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2021-05-12 19:08:39 UTC 
(In reply to vermaden from comment #5)
It is, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-05-13 05:45:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8ef98c9182e6e9f3ebdda623dc2ad0c51312a1eb

commit 8ef98c9182e6e9f3ebdda623dc2ad0c51312a1eb
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2021-05-12 19:03:31 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-05-13 05:41:33 +0000

    sysutils/lsblk: update to 3.4

     * Add sysctl -n kern.disks to disk listing.
     * Reset LABEL in __gpart_present function.
     * Fix behavior with [bootme] and [bootonce] flags from gpart(8).
     * Disable GPTID for label display.
     * Add -d|--disks option to list entire disks only.

    PR:     255807
    Reported by:    vermaden@interia.pl (maintainer)

 sysutils/lsblk/Makefile | 5 +++--
 sysutils/lsblk/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2021-05-13 05:47:03 UTC 
Committed,

Thanks!
Comment 9 Slawomir Wojciech Wojtczak 2021-05-13 06:58:04 UTC 
(In reply to Fernando Apesteguía from comment #8)

Thank You very much.

Have a good day :)

Regards.