Bug 255851 - [NEW PORT] games/py-legendarygl: Free and open-source Epic Games Launcher alternative
Summary: [NEW PORT] games/py-legendarygl: Free and open-source Epic Games Launcher alt...
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/derrod/legendary
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-05-13 20:42 UTC by Alexander Vereeken
Modified: 2023-08-09 14:33 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (Alexander88207)


Attachments
legendary.diff (9.07 KB, patch)
2021-05-13 20:42 UTC, Alexander Vereeken
no flags Details | Diff
legendary.diff (9.07 KB, patch)
2021-05-13 20:44 UTC, Alexander Vereeken
no flags Details | Diff
legendary.diff (9.07 KB, patch)
2021-05-13 20:47 UTC, Alexander Vereeken
no flags Details | Diff
legendary.diff (9.00 KB, patch)
2021-05-13 20:50 UTC, Alexander Vereeken
no flags Details | Diff
legendary(v2).diff (9.02 KB, patch)
2021-06-05 14:33 UTC, Alexander Vereeken
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Vereeken 2021-05-13 20:42:24 UTC
Created attachment 224912 [details]
legendary.diff

Legendary is an open-source game launcher that can download and install games from the Epic Games platform on Linux and Windows. Its name as a tongue-in-cheek play on tiers of item rarity in many MMORPGs.

WWW: https://github.com/derrod/legendary

Portlint -abct: looks fine
Poudriere: Not tested yet.
Comment 1 Alexander Vereeken 2021-05-13 20:44:52 UTC
Created attachment 224913 [details]
legendary.diff

Fix whitespace in pkg-descr
Comment 2 Alexander Vereeken 2021-05-13 20:47:21 UTC
Created attachment 224914 [details]
legendary.diff

place a missing tab in USE_Python
Comment 3 Alexander Vereeken 2021-05-13 20:50:15 UTC
Created attachment 224915 [details]
legendary.diff
Comment 4 Alexander Vereeken 2021-06-05 14:33:00 UTC
Created attachment 225572 [details]
legendary(v2).diff

Add NO_ARCH and set python version to at least 3.8 or higher.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-28 23:28:04 UTC
Review items:

- Upstream registered (PyPI) name is 'legendary-gl' [1]. Please rename
- Use CHEESESHOP as MASTER_SITES unless there's a reason not to
- All .py files without correcponsing pcy/pyo files (and pycache dirs too) in pkg-plist will cause leftovers on pkg uninstall, as they will be produced on first-run.

- The package has extra (optional) dependencies and features, consider adding OPTIONS for these:

    extras_require=dict(
        webview=['pywebview>=3.4'],
        webview_gtk=['pywebview>=3.4', 'PyGObject']
    ),

- Upstream only appears to declare support for 3.8-3.9. Test against 3.10 otherwise cap USES=python to -3.9, and ask upstream to test against and declare support for 3.10

Add USE_PYTHON= autoplist and concurrent (for the bin/ file)

- Update to latest (0.20.22 now)
- Add a little more to pkg-descr, maybe:

Features:

    * Authenticating with Epic's service
    * Downloading and installing your games and their DLC
    * Delta patching/updating of installed games
    * Launching games with online authentication (for multiplayer/DRM)
    * Syncing cloud saves (compatible with EGL)
    * Running games with WINE on Linux/macOS
    * Importing/Exporting installed games from/to the Epic Games Launcher

- Confirm the port passes QA (poudriere) and tests if the package provides a test suite.

[1] https://pypi.org/project/legendary-gl/